Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Conversation

@4brunu
Copy link
Contributor

@4brunu 4brunu commented Mar 3, 2022

Updates Moshi to 1.13.0

This was referenced Mar 3, 2022
@4brunu
Copy link
Contributor Author

4brunu commented Mar 3, 2022

@moljac I'm having the following error, but I don't know how to fix it.

       "/Users/user/Developer/XamarinComponents/Android/SquareMoshi/source/Square.Moshi.sln" (Restore target) (1) ->
       (Restore target) -> 
         /Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/NuGet.targets(131,5): error : Package Xamarin.Kotlin.StdLib.Jdk8 1.6.0 is not compatible with monoandroid11.0 (MonoAndroid,Version=v11.0). Package Xamarin.Kotlin.StdLib.Jdk8 1.6.0 supports: [/Users/user/Developer/XamarinComponents/Android/SquareMoshi/source/Square.Moshi.sln]
       /Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/NuGet.targets(131,5): error :   - monoandroid12.0 (MonoAndroid,Version=v12.0) [/Users/user/Developer/XamarinComponents/Android/SquareMoshi/source/Square.Moshi.sln]
       /Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/NuGet.targets(131,5): error :   - net6.0-android31.0 (.NETCoreApp,Version=v6.0) [/Users/user/Developer/XamarinComponents/Android/SquareMoshi/source/Square.Moshi.sln]

Do you have any idea how to fix this?

@4brunu
Copy link
Contributor Author

4brunu commented Mar 3, 2022

@moljac I was able to fix the error, and now it builds on my machine.

The CI is failling because that macOS CI image doesn't have monodroid12 installed, which is a requirement of Xamarin.Kotlin.StdLib.Jdk8 1.6.10 which is a dependency of Moshi.

So if I set monoandroid to less that 12, for example, 11, it show's the following error:

"/Users/user/Developer/XamarinComponents/Android/SquareMoshi/source/Square.Moshi.sln" (Restore target) (1) ->
(Restore target) -> 
  /Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/NuGet.targets(131,5): error : Package Xamarin.Kotlin.StdLib.Jdk8 1.6.10 is not compatible with monoandroid11.0 (MonoAndroid,Version=v11.0). Package Xamarin.Kotlin.StdLib.Jdk8 1.6.10 supports: [/Users/user/Developer/XamarinComponents/Android/SquareMoshi/source/Square.Moshi.sln]
/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/NuGet.targets(131,5): error :   - monoandroid12.0 (MonoAndroid,Version=v12.0) [/Users/user/Developer/XamarinComponents/Android/SquareMoshi/source/Square.Moshi.sln]
/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/NuGet.targets(131,5): error :   - net6.0-android31.0 (.NETCoreApp,Version=v6.0) [/Users/user/Developer/XamarinComponents/Android/SquareMoshi/source/Square.Moshi.```sln]

So I'm not sure what we should do to fix this error.
Is it possible to update CI to have monodroid12 installed?

@moljac
Copy link
Contributor

moljac commented Mar 3, 2022

@4brunu
Copy link
Contributor Author

4brunu commented Mar 3, 2022

It worked, CI is now passing, thanks 👍

@4brunu 4brunu closed this Mar 3, 2022
@4brunu 4brunu reopened this Mar 3, 2022
Copy link
Contributor

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moljac moljac merged commit 0a83f81 into xamarin:main Mar 4, 2022
@4brunu 4brunu deleted the feature/moshi1.13.0 branch May 11, 2022 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants