From eef8056a66da309def8007d70abc9950e474abc5 Mon Sep 17 00:00:00 2001 From: RafaelKayumov Date: Tue, 18 Nov 2025 14:25:21 +0300 Subject: [PATCH 1/2] Use navigationDestination API for product selector view presenting --- .../ProductSelector/ProductSelectorView.swift | 28 +++++++++++-------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/WooCommerce/Classes/ViewRelated/Products/ProductSelector/ProductSelectorView.swift b/WooCommerce/Classes/ViewRelated/Products/ProductSelector/ProductSelectorView.swift index 149c48130ad..e19e4063cf6 100644 --- a/WooCommerce/Classes/ViewRelated/Products/ProductSelector/ProductSelectorView.swift +++ b/WooCommerce/Classes/ViewRelated/Products/ProductSelector/ProductSelectorView.swift @@ -116,17 +116,23 @@ struct ProductSelectorView: View { .padding(Constants.defaultPadding) .accessibilityIdentifier(Constants.doneButtonAccessibilityIdentifier) .renderedIf(configuration.multipleSelectionEnabled && viewModel.syncApproach == .onButtonTap) - - if let variationListViewModel = viewModel.productVariationListViewModel { - LazyNavigationLink(destination: ProductVariationSelectorView( - isPresented: $isPresented, - viewModel: variationListViewModel, - onMultipleSelections: { selectedIDs in - viewModel.updateSelectedVariations(productID: variationListViewModel.productID, selectedVariationIDs: selectedIDs) - }), isActive: $viewModel.isShowingProductVariationList) { - EmptyView() - } - .renderedIf(configuration.treatsAllProductsAsSimple == false) + } + .if(configuration.treatsAllProductsAsSimple == false) { view in + view.navigationDestination(isPresented: $viewModel.isShowingProductVariationList) { + if let variationListViewModel = viewModel.productVariationListViewModel { + ProductVariationSelectorView( + isPresented: $isPresented, + viewModel: variationListViewModel, + onMultipleSelections: { selectedIDs in + viewModel.updateSelectedVariations( + productID: variationListViewModel.productID, + selectedVariationIDs: selectedIDs + ) + } + ) + } else { + EmptyView() + } } } .padding(.horizontal, insets: safeAreaInsets) From 394fc040e8d02e449b3549f6ba06e4826aff4b52 Mon Sep 17 00:00:00 2001 From: RafaelKayumov Date: Tue, 18 Nov 2025 14:56:55 +0300 Subject: [PATCH 2/2] Update release notes --- RELEASE-NOTES.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index e365785f354..6b60cb832da 100644 --- a/RELEASE-NOTES.txt +++ b/RELEASE-NOTES.txt @@ -3,7 +3,7 @@ 23.8 ----- - +- [Internal] Fix broken navigation to a variable product selector [https://github.com/woocommerce/woocommerce-ios/pull/16363] 23.7 -----