This repository was archived by the owner on Oct 4, 2019. It is now read-only.
Set featured image to first image if no position is provided and remove placeholder. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t image as a product's featured image. This also removes the placeholder image from the API response.
| if ( has_post_thumbnail( $variation->get_id() ) ) { | ||
| $attachment_id = $variation->get_image_id(); | ||
| } else { | ||
| $attachment_id = current( $variation->get_gallery_image_ids() ); |
Contributor
There was a problem hiding this comment.
By default product variations does not have galleries, this will be supported now on core?
Contributor
|
I still think that we could complete remove |
Author
|
@claudiosanches Okay completely removed position, which means I've put the updated schema in this PR as well, and fixed the variations function. |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two updates to the product/variations endpoints: