Skip to content

Commit b86a48a

Browse files
committed
fixup @annevk's feedback
1 parent ca52252 commit b86a48a

File tree

1 file changed

+28
-26
lines changed

1 file changed

+28
-26
lines changed

source

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -26066,8 +26066,9 @@ document.body.appendChild(wbr);</code></pre>
2606626066
<span>extract an origin</span> steps:</p>
2606726067

2606826068
<ol>
26069-
<li><p>If <span>this</span>'s <span data-x="concept-hyperlink-url">url</span> is null, return
26070-
null.</p></li>
26069+
<li><p>If <span>this</span>'s <span data-x="concept-hyperlink-url">url</span> is null, then
26070+
return null.</p></li>
26071+
2607126072
<li><p>Return <span>this</span>'s <span data-x="concept-hyperlink-url">url</span>'s
2607226073
<span data-x="concept-url-origin">origin</span>.</p></li>
2607326074
</ol>
@@ -92444,8 +92445,8 @@ interface <dfn interface data-x="dom-Origin-interface">Origin</dfn> {
9244492445
boolean <span data-x="dom-Origin-isSameSite">isSameSite</span>(Origin other);
9244592446
};</code></pre>
9244692447

92447-
<p><code data-x="dom-Origin-interface">Origin</code> objects have an
92448-
<dfn for="Origin" attribute>[[origin]]</dfn> internal slot, which holds an
92448+
<p><code data-x="dom-Origin-interface">Origin</code> objects have an associated
92449+
<dfn for="Origin" attribute data-x="dom-Origin-origin">origin</dfn>, which holds an
9244992450
<span>origin</span>.</p>
9245092451

9245192452
<p><span data-x="platform object">Platform objects</span> have an
@@ -92455,15 +92456,15 @@ interface <dfn interface data-x="dom-Origin-interface">Origin</dfn> {
9245592456
<div algorithm>
9245692457
<p>Objects implementing the <code data-x="dom-Origin-interface">Origin</code> interface's
9245792458
<span>extract an origin</span> steps are to return <span>this</span>'s
92458-
<span>[[origin]]</span>.</p>
92459+
<span data-x="dom-Origin-origin">origin</span>.</p>
9245992460
</div>
9246092461

9246192462
<div algorithm>
9246292463
<p>The <dfn constructor for="Origin"><code
9246392464
data-x="dom-Origin-constructor">new Origin()</code></dfn> constructor steps are:</p>
9246492465

9246592466
<ol>
92466-
<li><p>Set <span>this</span>'s <span>[[origin]]</span> internal slot to a unique
92467+
<li><p>Set <span>this</span>'s <span data-x="dom-Origin-origin">origin</span> to a unique
9246792468
<span data-x="concept-origin-opaque">opaque origin</span>.</p></li>
9246892469
</ol>
9246992470
</div>
@@ -92480,48 +92481,49 @@ interface <dfn interface data-x="dom-Origin-interface">Origin</dfn> {
9248092481
<ol>
9248192482
<li><p>Let <var>origin</var> be the result of executing <var>value</var>'s <span>extract an
9248292483
origin</span> operation.</p></li>
92483-
<li><p>If <var>origin</var> is not null, return a new
92484-
<code data-x="dom-Origin-interface">Origin</code> object whose <span>[[origin]]</span> is set
92485-
to <var>origin</var>.</p></li>
92484+
92485+
<li><p>If <var>origin</var> is not null, then return a new
92486+
<code data-x="dom-Origin-interface">Origin</code> object whose
92487+
<span data-x="dom-Origin-origin">origin</span> is set to <var>origin</var>.</p></li>
9248692488
</ol>
9248792489
</li>
92490+
9248892491
<li>
9248992492
<p>If <var>value</var> is a <span>string</span>:</p>
9249092493
<ol>
9249192494
<li><p>Let <var>parsed url</var> be the result of <span data-x="basic url parser">basic URL
9249292495
parsing</span> <var>value</var>.</p></li>
92493-
<li><p>If <var>parsed url</var> is not failure, return a new
92494-
<code data-x="dom-Origin-interface">Origin</code> object whose <span>[[origin]]</span> is set
92495-
to <var>parsed url</var>'s <span data-x="concept-url-origin">origin</span>.</p></li>
92496+
92497+
<li><p>If <var>parsed url</var> is not failure, then return a new
92498+
<code data-x="dom-Origin-interface">Origin</code> object whose
92499+
<span data-x="dom-Origin-origin">origin</span> is set to <var>parsed url</var>'s
92500+
<span data-x="concept-url-origin">origin</span>.</p></li>
9249692501
</ol>
92497-
</li>
92502+
</li>
92503+
9249892504
<li><p>Throw a <code>TypeError</code>.</p></li>
9249992505
</ol>
9250092506
</div>
9250192507

9250292508
<div algorithm>
9250392509
<p>The <dfn attribute for="Origin"><code data-x="dom-Origin-opaque">opaque</code></dfn> attribute
92504-
getter steps are to return true if <span>this</span>'s <span>[[origin]]</span> is an <span
92505-
data-x="concept-origin-opaque">opaque origin</span>, and false otherwise.</p>
92510+
getter steps are to return true if <span>this</span>'s
92511+
<span data-x="dom-Origin-origin">origin</span> is an <span data-x="concept-origin-opaque">opaque
92512+
origin</span>, and false otherwise.</p>
9250692513
</div>
9250792514

9250892515
<div algorithm>
9250992516
<p>The <dfn method for="Origin"><code
9251092517
data-x="dom-Origin-isSameOrigin">isSameOrigin(other)</code></dfn> method returns true if
92511-
<span>this</span>'s <span>[[origin]]</span> is <span>same origin</span> with <var>other</var>'s
92512-
<span>[[origin]]</span>, and false otherwise.</p>
92518+
<span>this</span>'s <span data-x="dom-Origin-origin">origin</span> is <span>same origin</span>
92519+
with <var>other</var>'s <span data-x="dom-Origin-origin">origin</span>, and false otherwise.</p>
9251392520
</div>
9251492521

9251592522
<div algorithm>
9251692523
<p>The <dfn method for="Origin"><code
9251792524
data-x="dom-Origin-isSameSite">isSameSite(other)</code></dfn> method returns true if
92518-
<span>this</span>'s <span>[[origin]]</span> is <span>same site</span> with <var>other</var>'s
92519-
<span>[[origin]]</span>, and false otherwise.</p>
92520-
92521-
<p class="note">This is a <span>same site</span>, <em>not</em> <span>schemelessly same
92522-
site</span>, comparison. For the reasons <a
92523-
href="https://url.spec.whatwg.org/#warning-avoid-psl">explained in <cite>URL</cite></a> The
92524-
<code data-x="dom-Origin-interface">Origin</code> origin does not offer schemeless comparison.</p>
92525+
<span>this</span>'s <span data-x="dom-Origin-origin">origin</span> is <span>same site</span> with
92526+
<var>other</var>'s <span data-x="dom-Origin-origin">origin</span>, and false otherwise.</p>
9252592527
</div>
9252692528

9252792529

@@ -123161,13 +123163,13 @@ document.body.appendChild(frame)</code></pre>
123161123163
<li><p>If <span>this</span>'s <span>relevant settings object</span>'s <span
123162123164
data-x="concept-settings-object-origin">origin</span> is not <span>same origin-domain</span>
123163123165
with the <span>entry settings object</span>'s <span
123164-
data-x="concept-settings-object-origin">origin</span>, return null.</p></li>
123166+
data-x="concept-settings-object-origin">origin</span>, then return null.</p></li>
123165123167

123166123168
<li><p>Return <span>this</span>'s return <span>this</span>'s <span>relevant settings
123167123169
object</span>'s <span data-x="concept-settings-object-origin">origin</span>.</p></li>
123168123170
</ol>
123169123171

123170-
<p class="note">Since these objects are potentially accessible cross-origin (e.g. through
123172+
<p class="note">Since these objects are potentially accessible cross-origin (e.g., through
123171123173
<code>WindowProxy</code>), we need a security check here before granting access to the origin.</p>
123172123174
</div>
123173123175

0 commit comments

Comments
 (0)