Rename method

Author: weswigham

internal/compiler/checkerpool.go

@@ -13,7 +13,7 @@ import (
 
 type CheckerPool interface {
 	GetChecker(ctx context.Context) (*checker.Checker, func())
-	GetCheckerForFile(ctx context.Context, file *ast.SourceFile) (*checker.Checker, func())
+	GetCheckerForFileNonexclusive(ctx context.Context, file *ast.SourceFile) (*checker.Checker, func())
 	GetCheckerForFileExclusive(ctx context.Context, file *ast.SourceFile) (*checker.Checker, func())
 	GetAllCheckers(ctx context.Context) ([]*checker.Checker, func())
 	Files(checker *checker.Checker) iter.Seq[*ast.SourceFile]
@@ -42,14 +42,14 @@ func newCheckerPool(checkerCount int, program *Program) *checkerPool {
 	return pool
 }
 
-func (p *checkerPool) GetCheckerForFile(ctx context.Context, file *ast.SourceFile) (*checker.Checker, func()) {
+func (p *checkerPool) GetCheckerForFileNonexclusive(ctx context.Context, file *ast.SourceFile) (*checker.Checker, func()) {
 	p.createCheckers()
 	checker := p.fileAssociations[file]
 	return checker, noop
 }
 
 func (p *checkerPool) GetCheckerForFileExclusive(ctx context.Context, file *ast.SourceFile) (*checker.Checker, func()) {
-	c, done := p.GetCheckerForFile(ctx, file)
+	c, done := p.GetCheckerForFileNonexclusive(ctx, file)
 	idx := slices.Index(p.checkers, c)
 	p.locks[idx].Lock()
 	return c, sync.OnceFunc(func() {

internal/compiler/emitHost.go

@@ -35,7 +35,7 @@ type emitHost struct {
 }
 
 func newEmitHost(ctx context.Context, program *Program, file *ast.SourceFile) (*emitHost, func()) {
-	checker, done := program.GetTypeCheckerForFile(ctx, file)
+	checker, done := program.GetTypeCheckerForFileNonexclusive(ctx, file)
 	return &emitHost{
 		program:      program,
 		emitResolver: checker.GetEmitResolver(),

internal/compiler/program.go

@@ -379,8 +379,8 @@ func (p *Program) GetTypeCheckers(ctx context.Context) ([]*checker.Checker, func
 // method returns the checker that was tasked with checking the file. Note that it isn't possible to mix
 // types obtained from different checkers, so only non-type data (such as diagnostics or string
 // representations of types) should be obtained from checkers returned by this method.
-func (p *Program) GetTypeCheckerForFile(ctx context.Context, file *ast.SourceFile) (*checker.Checker, func()) {
-	return p.checkerPool.GetCheckerForFile(ctx, file)
+func (p *Program) GetTypeCheckerForFileNonexclusive(ctx context.Context, file *ast.SourceFile) (*checker.Checker, func()) {
+	return p.checkerPool.GetCheckerForFileNonexclusive(ctx, file)
 }
 
 // Return a checker for the given file, locked to the current thread to prevent data races from multiple threads
@@ -1029,7 +1029,7 @@ func (p *Program) getSemanticDiagnosticsForFileNotFilter(ctx context.Context, so
 	var fileChecker *checker.Checker
 	var done func()
 	if sourceFile != nil {
-		fileChecker, done = p.checkerPool.GetCheckerForFile(ctx, sourceFile)
+		fileChecker, done = p.checkerPool.GetCheckerForFileNonexclusive(ctx, sourceFile)
 		defer done()
 	}
 	diags := slices.Clip(sourceFile.BindDiagnostics())
@@ -1134,7 +1134,7 @@ func (p *Program) getSuggestionDiagnosticsForFile(ctx context.Context, sourceFil
 	var fileChecker *checker.Checker
 	var done func()
 	if sourceFile != nil {
-		fileChecker, done = p.checkerPool.GetCheckerForFile(ctx, sourceFile)
+		fileChecker, done = p.checkerPool.GetCheckerForFileNonexclusive(ctx, sourceFile)
 		defer done()
 	}
 

internal/ls/api.go

@@ -24,14 +24,14 @@ func (l *LanguageService) GetSymbolAtPosition(ctx context.Context, fileName stri
 	if node == nil {
 		return nil, fmt.Errorf("%w: %s:%d", ErrNoTokenAtPosition, fileName, position)
 	}
-	checker, done := program.GetTypeCheckerForFile(ctx, file)
+	checker, done := program.GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 	return checker.GetSymbolAtLocation(node), nil
 }
 
 func (l *LanguageService) GetSymbolAtLocation(ctx context.Context, node *ast.Node) *ast.Symbol {
 	program := l.GetProgram()
-	checker, done := program.GetTypeCheckerForFile(ctx, ast.GetSourceFileOfNode(node))
+	checker, done := program.GetTypeCheckerForFileNonexclusive(ctx, ast.GetSourceFileOfNode(node))
 	defer done()
 	return checker.GetSymbolAtLocation(node)
 }

internal/ls/completions.go

@@ -388,7 +388,7 @@ func (l *LanguageService) getCompletionsAtPosition(
 		)
 	}
 
-	checker, done := l.GetProgram().GetTypeCheckerForFile(ctx, file)
+	checker, done := l.GetProgram().GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 	preferences := l.UserPreferences()
 	data := l.getCompletionData(ctx, checker, file, position, preferences)
@@ -1941,7 +1941,7 @@ func (l *LanguageService) getCompletionEntriesFromSymbols(
 ) (uniqueNames collections.Set[string], sortedEntries []*lsproto.CompletionItem) {
 	closestSymbolDeclaration := getClosestSymbolDeclaration(data.contextToken, data.location)
 	useSemicolons := lsutil.ProbablyUsesSemicolons(file)
-	typeChecker, done := l.GetProgram().GetTypeCheckerForFile(ctx, file)
+	typeChecker, done := l.GetProgram().GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 	isMemberCompletion := isMemberCompletionKind(data.completionKind)
 	// Tracks unique names.
@@ -5056,7 +5056,7 @@ func (l *LanguageService) getCompletionItemDetails(
 	itemData *CompletionItemData,
 	clientOptions *lsproto.CompletionClientCapabilities,
 ) *lsproto.CompletionItem {
-	checker, done := program.GetTypeCheckerForFile(ctx, file)
+	checker, done := program.GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 	docFormat := getCompletionDocumentationFormat(clientOptions)
 	contextToken, previousToken := getRelevantTokens(position, file)

internal/ls/definition.go

@@ -26,7 +26,7 @@ func (l *LanguageService) ProvideDefinition(
 	}
 	originSelectionRange := l.createLspRangeFromNode(node, file)
 
-	c, done := program.GetTypeCheckerForFile(ctx, file)
+	c, done := program.GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 
 	if node.Kind == ast.KindOverrideKeyword {
@@ -77,7 +77,7 @@ func (l *LanguageService) ProvideTypeDefinition(
 	}
 	originSelectionRange := l.createLspRangeFromNode(node, file)
 
-	c, done := program.GetTypeCheckerForFile(ctx, file)
+	c, done := program.GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 
 	node = getDeclarationNameForKeyword(node)

internal/ls/hover.go

@@ -25,7 +25,7 @@ func (l *LanguageService) ProvideHover(ctx context.Context, documentURI lsproto.
 		// Avoid giving quickInfo for the sourceFile as a whole.
 		return lsproto.HoverOrNull{}, nil
 	}
-	c, done := program.GetTypeCheckerForFile(ctx, file)
+	c, done := program.GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 	rangeNode := getNodeForQuickInfo(node)
 	quickInfo, documentation := l.getQuickInfoAndDocumentationForSymbol(c, c.GetSymbolAtLocation(node), rangeNode, contentFormat)

internal/ls/inlay_hints.go

@@ -31,7 +31,7 @@ func (l *LanguageService) ProvideInlayHint(
 	program, file := l.getProgramAndFile(params.TextDocument.Uri)
 	quotePreference := getQuotePreference(file, l.UserPreferences())
 
-	checker, done := program.GetTypeCheckerForFile(ctx, file)
+	checker, done := program.GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 	inlayHintState := &inlayHintState{
 		ctx:             ctx,

internal/ls/signaturehelp.go

@@ -67,7 +67,7 @@ func (l *LanguageService) GetSignatureHelpItems(
 	clientOptions *lsproto.SignatureHelpClientCapabilities,
 	docFormat lsproto.MarkupKind,
 ) *lsproto.SignatureHelp {
-	typeChecker, done := program.GetTypeCheckerForFile(ctx, sourceFile)
+	typeChecker, done := program.GetTypeCheckerForFileNonexclusive(ctx, sourceFile)
 	defer done()
 
 	// Decide whether to show signature help

internal/ls/string_completions.go

@@ -225,7 +225,7 @@ func (l *LanguageService) getStringLiteralCompletionEntries(
 	node *ast.StringLiteralLike,
 	position int,
 ) *stringLiteralCompletions {
-	typeChecker, done := l.GetProgram().GetTypeCheckerForFile(ctx, file)
+	typeChecker, done := l.GetProgram().GetTypeCheckerForFileNonexclusive(ctx, file)
 	defer done()
 	parent := walkUpParentheses(node.Parent)
 	switch parent.Kind {