Tons of fourslash changes?

Author: weswigham

internal/fourslash/_scripts/failingTests.txt

@@ -1,187 +1,5 @@
-TestAliasMergingWithNamespace
-TestAmbientShorthandGotoDefinition
-TestArgumentsAreAvailableAfterEditsAtEndOfFunction
-TestAugmentedTypesClass1
-TestAugmentedTypesClass3Fourslash
-TestBestCommonTypeObjectLiterals
-TestBestCommonTypeObjectLiterals1
-TestCodeCompletionEscaping
-TestCommentsEnumsFourslash
-TestCommentsLinePreservation
-TestCommentsUnion
-TestCompletionAfterQuestionDot
-TestCompletionAutoInsertQuestionDot
-TestCompletionCloneQuestionToken
-TestCompletionEntryForArgumentConstrainedToString
-TestCompletionEntryForArrayElementConstrainedToString
-TestCompletionEntryForArrayElementConstrainedToString2
-TestCompletionEntryForClassMembers_StaticWhenBaseTypeIsNotResolved
-TestCompletionEntryForUnionProperty
-TestCompletionEntryForUnionProperty2
-TestCompletionExportFrom
-TestCompletionForComputedStringProperties
-TestCompletionForMetaProperty
-TestCompletionForStringLiteral
-TestCompletionForStringLiteral4
-TestCompletionForStringLiteralExport
-TestCompletionForStringLiteralImport1
-TestCompletionForStringLiteralImport2
-TestCompletionForStringLiteralNonrelativeImport12
-TestCompletionForStringLiteralNonrelativeImport14
-TestCompletionForStringLiteralNonrelativeImport16
-TestCompletionForStringLiteralNonrelativeImport17
-TestCompletionForStringLiteralNonrelativeImport18
-TestCompletionForStringLiteralNonrelativeImport2
-TestCompletionForStringLiteralNonrelativeImport3
-TestCompletionForStringLiteralNonrelativeImport4
-TestCompletionForStringLiteralNonrelativeImport7
-TestCompletionForStringLiteralNonrelativeImport8
-TestCompletionForStringLiteralNonrelativeImport9
-TestCompletionForStringLiteralNonrelativeImportTypings1
-TestCompletionForStringLiteralNonrelativeImportTypings2
-TestCompletionForStringLiteralNonrelativeImportTypings3
-TestCompletionForStringLiteralRelativeImport4
-TestCompletionForStringLiteralRelativeImport6
-TestCompletionForStringLiteralRelativeImportAllowJSTrue
-TestCompletionForStringLiteralWithDynamicImport
-TestCompletionForStringLiteral_details
-TestCompletionForStringLiteral_quotePreference
-TestCompletionForStringLiteral_quotePreference1
-TestCompletionForStringLiteral_quotePreference2
-TestCompletionForStringLiteral_quotePreference3
-TestCompletionForStringLiteral_quotePreference4
-TestCompletionForStringLiteral_quotePreference5
-TestCompletionForStringLiteral_quotePreference6
-TestCompletionForStringLiteral_quotePreference7
-TestCompletionForStringLiteral_quotePreference8
-TestCompletionImportMeta
-TestCompletionImportMetaWithGlobalDeclaration
-TestCompletionImportModuleSpecifierEndingDts
-TestCompletionImportModuleSpecifierEndingJs
-TestCompletionImportModuleSpecifierEndingJsx
-TestCompletionImportModuleSpecifierEndingTs
-TestCompletionImportModuleSpecifierEndingTsxPreserve
-TestCompletionImportModuleSpecifierEndingTsxReact
-TestCompletionImportModuleSpecifierEndingUnsupportedExtension
-TestCompletionInFunctionLikeBody_includesPrimitiveTypes
-TestCompletionInJsDoc
-TestCompletionInNamedImportLocation
-TestCompletionInUncheckedJSFile
-TestCompletionListBuilderLocations_VariableDeclarations
-TestCompletionListForDerivedType1
-TestCompletionListForTransitivelyExportedMembers04
-TestCompletionListFunctionExpression
-TestCompletionListInArrowFunctionInUnclosedCallSite01
-TestCompletionListInClassExpressionWithTypeParameter
-TestCompletionListInClassStaticBlocks
-TestCompletionListInImportClause01
-TestCompletionListInImportClause05
-TestCompletionListInImportClause06
-TestCompletionListInNamedClassExpression
-TestCompletionListInNamedClassExpressionWithShadowing
-TestCompletionListInNamedFunctionExpression
-TestCompletionListInNamedFunctionExpression1
-TestCompletionListInNamedFunctionExpressionWithShadowing
-TestCompletionListInScope
-TestCompletionListInTemplateLiteralParts1
-TestCompletionListInUnclosedCommaExpression01
-TestCompletionListInUnclosedCommaExpression02
-TestCompletionListInUnclosedFunction08
-TestCompletionListInUnclosedFunction09
-TestCompletionListInUnclosedTaggedTemplate01
-TestCompletionListInUnclosedTaggedTemplate02
-TestCompletionListInUnclosedTemplate01
-TestCompletionListInUnclosedTemplate02
-TestCompletionListInvalidMemberNames
-TestCompletionListInvalidMemberNames2
-TestCompletionListInvalidMemberNames_escapeQuote
-TestCompletionListInvalidMemberNames_startWithSpace
-TestCompletionListInvalidMemberNames_withExistingIdentifier
-TestCompletionListObjectMembersInTypeLocationWithTypeof
-TestCompletionListOfGenericSymbol
-TestCompletionListOnAliases
-TestCompletionListStringParenthesizedExpression
-TestCompletionListStringParenthesizedType
-TestCompletionListWithoutVariableinitializer
-TestCompletionListsStringLiteralTypeAsIndexedAccessTypeObject
-TestCompletionNoAutoInsertQuestionDotForThis
-TestCompletionNoAutoInsertQuestionDotForTypeParameter
-TestCompletionNoAutoInsertQuestionDotWithUserPreferencesOff
-TestCompletionOfAwaitPromise1
-TestCompletionOfAwaitPromise2
-TestCompletionOfAwaitPromise3
-TestCompletionOfAwaitPromise5
-TestCompletionOfAwaitPromise6
-TestCompletionOfAwaitPromise7
-TestCompletionOfInterfaceAndVar
-TestCompletionPreferredSuggestions1
-TestCompletionWithConditionalOperatorMissingColon
-TestCompletionsAfterJSDoc
-TestCompletionsBeforeRestArg1
-TestCompletionsElementAccessNumeric
-TestCompletionsExportImport
-TestCompletionsGenericTypeWithMultipleBases1
-TestCompletionsImportOrExportSpecifier
-TestCompletionsInExport
-TestCompletionsInExport_moduleBlock
-TestCompletionsInRequire
-TestCompletionsJSDocImportTagAttributesEmptyModuleSpecifier1
-TestCompletionsJSDocImportTagAttributesErrorModuleSpecifier1
-TestCompletionsJSDocImportTagEmptyModuleSpecifier1
-TestCompletionsJSDocNoCrash1
-TestCompletionsJsdocTypeTagCast
-TestCompletionsJsxAttribute2
-TestCompletionsJsxAttributeInitializer2
-TestCompletionsLiteralFromInferenceWithinInferredType3
-TestCompletionsLiterals
-TestCompletionsMergedDeclarations1
-TestCompletionsNewTarget
-TestCompletionsOptionalMethod
-TestCompletionsOverridingMethod1
-TestCompletionsOverridingMethod10
-TestCompletionsOverridingMethod11
-TestCompletionsOverridingMethod14
-TestCompletionsOverridingMethod17
-TestCompletionsOverridingMethod3
-TestCompletionsOverridingMethod4
-TestCompletionsOverridingMethod9
-TestCompletionsOverridingMethodCrash1
-TestCompletionsOverridingProperties1
-TestCompletionsPathsJsonModule
-TestCompletionsPathsRelativeJsonModule
-TestCompletionsPaths_importType
-TestCompletionsPaths_kinds
-TestCompletionsPaths_pathMapping
-TestCompletionsPaths_pathMapping_nonTrailingWildcard1
-TestCompletionsPaths_pathMapping_parentDirectory
-TestCompletionsRecommended_union
-TestCompletionsRedeclareModuleAsGlobal
-TestCompletionsStringsWithTriggerCharacter
-TestCompletionsSymbolMembers
-TestCompletionsTriggerCharacter
-TestCompletionsTuple
-TestCompletionsUniqueSymbol1
-TestConstEnumQuickInfoAndCompletionList
-TestConstQuickInfoAndCompletionList
-TestContextuallyTypedFunctionExpressionGeneric1
-TestDoubleUnderscoreCompletions
-TestEditJsdocType
-TestExportDefaultClass
-TestExportDefaultFunction
-TestFindAllReferencesDynamicImport1
-TestFindAllReferencesTripleSlash
-TestFindAllReferencesUmdModuleAsGlobalConst
-TestFindAllRefsCommonJsRequire
-TestFindAllRefsCommonJsRequire2
-TestFindAllRefsCommonJsRequire3
-TestFindAllRefsExportEquals
-TestFindAllRefsForDefaultExport03
-TestFindAllRefsModuleDotExports
-TestFindAllRefsReExport_broken
 TestFindAllRefs_importType_typeofImport
 TestFindReferencesAfterEdit
-TestFindReferencesBindingPatternInJsdocNoCrash1
-TestFindReferencesBindingPatternInJsdocNoCrash2
 TestGenericCombinatorWithConstraints1
 TestGenericCombinators3
 TestGenericFunctionWithGenericParams1
@@ -386,91 +204,15 @@ TestQuickInfoOnArgumentsInsideFunction
 TestQuickInfoOnCatchVariable
 TestQuickInfoOnClosingJsx
 TestQuickInfoOnElementAccessInWriteLocation1
-TestQuickInfoOnElementAccessInWriteLocation2
-TestQuickInfoOnElementAccessInWriteLocation3
-TestQuickInfoOnElementAccessInWriteLocation4
-TestQuickInfoOnElementAccessInWriteLocation5
-TestQuickInfoOnErrorTypes1
-TestQuickInfoOnFunctionPropertyReturnedFromGenericFunction1
-TestQuickInfoOnFunctionPropertyReturnedFromGenericFunction2
-TestQuickInfoOnFunctionPropertyReturnedFromGenericFunction3
-TestQuickInfoOnGenericWithConstraints1
-TestQuickInfoOnInternalAliases
-TestQuickInfoOnMethodOfImportEquals
-TestQuickInfoOnNarrowedType
-TestQuickInfoOnNarrowedTypeInModule
-TestQuickInfoOnNewKeyword01
-TestQuickInfoOnObjectLiteralWithAccessors
-TestQuickInfoOnObjectLiteralWithOnlyGetter
-TestQuickInfoOnObjectLiteralWithOnlySetter
-TestQuickInfoOnPropDeclaredUsingIndexSignatureOnInterfaceWithBase
-TestQuickInfoOnPropertyAccessInWriteLocation1
-TestQuickInfoOnPropertyAccessInWriteLocation2
-TestQuickInfoOnPropertyAccessInWriteLocation3
-TestQuickInfoOnPropertyAccessInWriteLocation4
-TestQuickInfoOnPropertyAccessInWriteLocation5
-TestQuickInfoOnThis
-TestQuickInfoOnThis2
-TestQuickInfoOnThis3
-TestQuickInfoOnThis4
-TestQuickInfoOnUndefined
-TestQuickInfoOnVarInArrowExpression
-TestQuickInfoPrivateIdentifierInTypeReferenceNoCrash1
-TestQuickInfoPropertyTag
-TestQuickInfoSignatureOptionalParameterFromUnion1
-TestQuickInfoSignatureRestParameterFromUnion1
-TestQuickInfoSignatureRestParameterFromUnion2
-TestQuickInfoSignatureRestParameterFromUnion3
-TestQuickInfoSignatureRestParameterFromUnion4
-TestQuickInfoSpecialPropertyAssignment
-TestQuickInfoStaticPrototypePropertyOnClass
-TestQuickInfoTemplateTag
-TestQuickInfoTypeAliasDefinedInDifferentFile
-TestQuickInfoTypeError
-TestQuickInfoTypeOfThisInStatics
-TestQuickInfoTypeOnlyNamespaceAndClass
-TestQuickInfoUnionOfNamespaces
-TestQuickInfoUnion_discriminated
-TestQuickInfoWidenedTypes
 TestQuickInfo_notInsideComment
 TestQuickInforForSucessiveInferencesIsNotAny
 TestQuickinfo01
 TestQuickinfoForNamespaceMergeWithClassConstrainedToSelf
 TestQuickinfoForUnionProperty
 TestQuickinfoWrongComment
 TestRecursiveInternalModuleImport
-TestReferencesForExportedValues
-TestReferencesForStatementKeywords
-TestReferencesInComment
-TestReferencesInEmptyFile
-TestReferencesIsAvailableThroughGlobalNoCrash
-TestRegexDetection
-TestReverseMappedTypeQuickInfo
-TestSelfReferencedExternalModule
-TestSignatureHelpInferenceJsDocImportTag
-TestStringCompletionsImportOrExportSpecifier
-TestStringCompletionsVsEscaping
-TestSyntheticImportFromBabelGeneratedFile1
-TestSyntheticImportFromBabelGeneratedFile2
-TestThisBindingInLambda
-TestThisPredicateFunctionQuickInfo01
-TestThisPredicateFunctionQuickInfo02
-TestTripleSlashRefPathCompletionAbsolutePaths
-TestTripleSlashRefPathCompletionContext
-TestTripleSlashRefPathCompletionExtensionsAllowJSFalse
-TestTripleSlashRefPathCompletionExtensionsAllowJSTrue
-TestTripleSlashRefPathCompletionHiddenFile
-TestTripleSlashRefPathCompletionRootdirs
-TestTslibFindAllReferencesOnRuntimeImportWithPaths1
-TestTsxCompletion12
-TestTsxCompletion13
-TestTsxCompletion14
-TestTsxCompletion15
 TestTsxCompletion8
 TestTsxCompletionNonTagLessThan
 TestTsxQuickInfo1
 TestTsxQuickInfo4
 TestTsxQuickInfo5
-TestTsxQuickInfo6
-TestTsxQuickInfo7
-TestTypeOperatorNodeBuilding

internal/fourslash/tests/gen/aliasMergingWithNamespace_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestAliasMergingWithNamespace(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `namespace bar { }
 import bar = bar/**/;`

internal/fourslash/tests/gen/ambientShorthandGotoDefinition_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestAmbientShorthandGotoDefinition(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @Filename: declarations.d.ts
 declare module /*module*/"jquery"

internal/fourslash/tests/gen/argumentsAreAvailableAfterEditsAtEndOfFunction_test.go

@@ -11,7 +11,7 @@ import (
 
 func TestArgumentsAreAvailableAfterEditsAtEndOfFunction(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `module Test1 {
 	class Person {

internal/fourslash/tests/gen/augmentedTypesClass1_test.go

@@ -11,7 +11,7 @@ import (
 
 func TestAugmentedTypesClass1(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `class c5b { public foo() { } }
 module c5b { export var y = 2; } // should be ok

internal/fourslash/tests/gen/augmentedTypesClass3Fourslash_test.go

@@ -11,7 +11,7 @@ import (
 
 func TestAugmentedTypesClass3Fourslash(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `class c/*1*/5b { public foo() { } }
 namespace c/*2*/5b { export var y = 2; } // should be ok

internal/fourslash/tests/gen/bestCommonTypeObjectLiterals1_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestBestCommonTypeObjectLiterals1(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `var a = { name: 'bob', age: 18 };
 var b = { name: 'jim', age: 20 };

internal/fourslash/tests/gen/bestCommonTypeObjectLiterals_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestBestCommonTypeObjectLiterals(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `var a = { name: 'bob', age: 18 };
 var b = { name: 'jim', age: 20 };

internal/fourslash/tests/gen/codeCompletionEscaping_test.go

@@ -12,7 +12,7 @@ import (
 
 func TestCodeCompletionEscaping(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @Filename: a.js
 // @allowJs: true

internal/fourslash/tests/gen/commentsEnumsFourslash_test.go

@@ -11,7 +11,7 @@ import (
 
 func TestCommentsEnumsFourslash(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `/** Enum of colors*/
 enum /*1*/Colors {