Skip to content

Commit 9866a56

Browse files
author
Mathieu Martin
committed
Reinforce the exclusion of the leading dot from url.extension (elastic#1151)
1 parent 12e8827 commit 9866a56

File tree

11 files changed

+51
-22
lines changed

11 files changed

+51
-22
lines changed

code/go/ecs/url.go

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/field-details.asciidoc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6247,12 +6247,14 @@ example: `www.elastic.co`
62476247
// ===============================================================
62486248

62496249
| url.extension
6250-
| The field contains the file extension from the original request url.
6250+
| The field contains the file extension from the original request url, excluding the leading dot.
62516251

62526252
The file extension is only set if it exists, as not every url has a file extension.
62536253

62546254
The leading period must not be included. For example, the value must be "png", not ".png".
62556255

6256+
Note that when the file name has multiple extensions (example.tar.gz), only the last one should be captured ("gz", not "tar.gz").
6257+
62566258
type: keyword
62576259

62586260

experimental/generated/beats/fields.ecs.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5269,12 +5269,15 @@
52695269
type: keyword
52705270
ignore_above: 1024
52715271
description: 'The field contains the file extension from the original request
5272-
url.
5272+
url, excluding the leading dot.
52735273
52745274
The file extension is only set if it exists, as not every url has a file extension.
52755275
52765276
The leading period must not be included. For example, the value must be "png",
5277-
not ".png".'
5277+
not ".png".
5278+
5279+
Note that when the file name has multiple extensions (example.tar.gz), only
5280+
the last one should be captured ("gz", not "tar.gz").'
52785281
example: png
52795282
- name: fragment
52805283
level: extended

experimental/generated/csv/fields.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
631631
1.8.0-dev+exp,true,trace,trace.id,keyword,extended,,4bf92f3577b34da6a3ce929d0e0e4736,Unique identifier of the trace.
632632
1.8.0-dev+exp,true,transaction,transaction.id,keyword,extended,,00f067aa0ba902b7,Unique identifier of the transaction within the scope of its trace.
633633
1.8.0-dev+exp,true,url,url.domain,wildcard,extended,,www.elastic.co,Domain of the url.
634-
1.8.0-dev+exp,true,url,url.extension,keyword,extended,,png,File extension from the original request url.
634+
1.8.0-dev+exp,true,url,url.extension,keyword,extended,,png,"File extension from the request url, excluding the leading dot."
635635
1.8.0-dev+exp,true,url,url.fragment,keyword,extended,,,Portion of the url after the `#`.
636636
1.8.0-dev+exp,true,url,url.full,wildcard,extended,,https://www.elastic.co:443/search?q=elasticsearch#top,Full unparsed URL.
637637
1.8.0-dev+exp,true,url,url.full.text,text,extended,,https://www.elastic.co:443/search?q=elasticsearch#top,Full unparsed URL.

experimental/generated/ecs/ecs_flat.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8037,19 +8037,23 @@ url.domain:
80378037
type: wildcard
80388038
url.extension:
80398039
dashed_name: url-extension
8040-
description: 'The field contains the file extension from the original request url.
8040+
description: 'The field contains the file extension from the original request url,
8041+
excluding the leading dot.
80418042
80428043
The file extension is only set if it exists, as not every url has a file extension.
80438044
80448045
The leading period must not be included. For example, the value must be "png",
8045-
not ".png".'
8046+
not ".png".
8047+
8048+
Note that when the file name has multiple extensions (example.tar.gz), only the
8049+
last one should be captured ("gz", not "tar.gz").'
80468050
example: png
80478051
flat_name: url.extension
80488052
ignore_above: 1024
80498053
level: extended
80508054
name: extension
80518055
normalize: []
8052-
short: File extension from the original request url.
8056+
short: File extension from the request url, excluding the leading dot.
80538057
type: keyword
80548058
url.fragment:
80558059
dashed_name: url-fragment

experimental/generated/ecs/ecs_nested.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9302,19 +9302,22 @@ url:
93029302
url.extension:
93039303
dashed_name: url-extension
93049304
description: 'The field contains the file extension from the original request
9305-
url.
9305+
url, excluding the leading dot.
93069306
93079307
The file extension is only set if it exists, as not every url has a file extension.
93089308
93099309
The leading period must not be included. For example, the value must be "png",
9310-
not ".png".'
9310+
not ".png".
9311+
9312+
Note that when the file name has multiple extensions (example.tar.gz), only
9313+
the last one should be captured ("gz", not "tar.gz").'
93119314
example: png
93129315
flat_name: url.extension
93139316
ignore_above: 1024
93149317
level: extended
93159318
name: extension
93169319
normalize: []
9317-
short: File extension from the original request url.
9320+
short: File extension from the request url, excluding the leading dot.
93189321
type: keyword
93199322
url.fragment:
93209323
dashed_name: url-fragment

generated/beats/fields.ecs.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5357,12 +5357,15 @@
53575357
type: keyword
53585358
ignore_above: 1024
53595359
description: 'The field contains the file extension from the original request
5360-
url.
5360+
url, excluding the leading dot.
53615361
53625362
The file extension is only set if it exists, as not every url has a file extension.
53635363
53645364
The leading period must not be included. For example, the value must be "png",
5365-
not ".png".'
5365+
not ".png".
5366+
5367+
Note that when the file name has multiple extensions (example.tar.gz), only
5368+
the last one should be captured ("gz", not "tar.gz").'
53665369
example: png
53675370
- name: fragment
53685371
level: extended

generated/csv/fields.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
631631
1.8.0-dev,true,trace,trace.id,keyword,extended,,4bf92f3577b34da6a3ce929d0e0e4736,Unique identifier of the trace.
632632
1.8.0-dev,true,transaction,transaction.id,keyword,extended,,00f067aa0ba902b7,Unique identifier of the transaction within the scope of its trace.
633633
1.8.0-dev,true,url,url.domain,keyword,extended,,www.elastic.co,Domain of the url.
634-
1.8.0-dev,true,url,url.extension,keyword,extended,,png,File extension from the original request url.
634+
1.8.0-dev,true,url,url.extension,keyword,extended,,png,"File extension from the request url, excluding the leading dot."
635635
1.8.0-dev,true,url,url.fragment,keyword,extended,,,Portion of the url after the `#`.
636636
1.8.0-dev,true,url,url.full,keyword,extended,,https://www.elastic.co:443/search?q=elasticsearch#top,Full unparsed URL.
637637
1.8.0-dev,true,url,url.full.text,text,extended,,https://www.elastic.co:443/search?q=elasticsearch#top,Full unparsed URL.

generated/ecs/ecs_flat.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8121,19 +8121,23 @@ url.domain:
81218121
type: keyword
81228122
url.extension:
81238123
dashed_name: url-extension
8124-
description: 'The field contains the file extension from the original request url.
8124+
description: 'The field contains the file extension from the original request url,
8125+
excluding the leading dot.
81258126
81268127
The file extension is only set if it exists, as not every url has a file extension.
81278128
81288129
The leading period must not be included. For example, the value must be "png",
8129-
not ".png".'
8130+
not ".png".
8131+
8132+
Note that when the file name has multiple extensions (example.tar.gz), only the
8133+
last one should be captured ("gz", not "tar.gz").'
81308134
example: png
81318135
flat_name: url.extension
81328136
ignore_above: 1024
81338137
level: extended
81348138
name: extension
81358139
normalize: []
8136-
short: File extension from the original request url.
8140+
short: File extension from the request url, excluding the leading dot.
81378141
type: keyword
81388142
url.fragment:
81398143
dashed_name: url-fragment

generated/ecs/ecs_nested.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9391,19 +9391,22 @@ url:
93919391
url.extension:
93929392
dashed_name: url-extension
93939393
description: 'The field contains the file extension from the original request
9394-
url.
9394+
url, excluding the leading dot.
93959395
93969396
The file extension is only set if it exists, as not every url has a file extension.
93979397
93989398
The leading period must not be included. For example, the value must be "png",
9399-
not ".png".'
9399+
not ".png".
9400+
9401+
Note that when the file name has multiple extensions (example.tar.gz), only
9402+
the last one should be captured ("gz", not "tar.gz").'
94009403
example: png
94019404
flat_name: url.extension
94029405
ignore_above: 1024
94039406
level: extended
94049407
name: extension
94059408
normalize: []
9406-
short: File extension from the original request url.
9409+
short: File extension from the request url, excluding the leading dot.
94079410
type: keyword
94089411
url.fragment:
94099412
dashed_name: url-fragment

0 commit comments

Comments
 (0)