Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented May 22, 2020

Description

Deprecates Web3's websocket fork, reverting to the parent package. The patch for global this which originally prompted the fork was accepted and published upstream.

Additional bug-fixes have been made there in the intervening months which should resolve #3371.

Fixes #3371: windows installation errors are gone

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented May 22, 2020

Coverage Status

Coverage remained the same at 89.602% when pulling 6aa3e60 on issue/3371 into 740a982 on 1.x.

@cgewecke cgewecke added 1.x 1.0 related issues Bug Addressing a bug dependencies Review Needed Maintainer(s) need to review labels May 22, 2020
Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Bug Addressing a bug Review Needed Maintainer(s) need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update websocket fork (node-gyp err output on Windows / Node 12)

4 participants