Dev update #21
Merged
Dev update #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rough cut at moving HUD views into their own framework. * Move view code into the HUDViewKit framework directory * Remove HUDViewKit * Add GlucoseTrend and NSTimeInterval directly to WatchApp Extension so that it doesn't have to pull in HUDViewKit * Get all targets to compile with HUDViewKit 1. Make HKUnit extension internal and included it directly into all necessary targets to avoid a conflict with the same extension in LoopKit 2. Publicize any necessary HUDViewKit vars, funcs 3. Store the Int raw value for GlucoseTrend in WatchContext and create a computed property that returns it as a GlucoseTrend object to avoid the conflict where both Loop and WatchApp Extension have their own separate concept of GlucoseTrend. * Rename HUDViewKit to LoopUI * partway through moving layout * WIP * Resize stack view to fill container view * Embed LoopUI framework * Use NibLoadable for HUDView
* Monitor changes and update the widget in real time. Use KVO to watch the UserDefaults object and update the view as appropriate. * Clean up observer implementation 1. call addObserver() in viewDidLoad() 2. call removeObserver() in deinit 3. don't specify options in addObserver() 4. provide a context to the observer code * Move early-return semantics into a guard statement. * Use an explicit, separately named context for observer.
* Use a clear fill color for the circle. * Oops! Forgot to set the clear color for init?(coder:) as well
…archy (#352) * Rough cut at moving HUD views into their own framework. * Move view code into the HUDViewKit framework directory * Remove HUDViewKit * Add GlucoseTrend and NSTimeInterval directly to WatchApp Extension so that it doesn't have to pull in HUDViewKit * Get all targets to compile with HUDViewKit 1. Make HKUnit extension internal and included it directly into all necessary targets to avoid a conflict with the same extension in LoopKit 2. Publicize any necessary HUDViewKit vars, funcs 3. Store the Int raw value for GlucoseTrend in WatchContext and create a computed property that returns it as a GlucoseTrend object to avoid the conflict where both Loop and WatchApp Extension have their own separate concept of GlucoseTrend. * Rename HUDViewKit to LoopUI * partway through moving layout * WIP * Resize stack view to fill container view * Embed LoopUI framework * Use NibLoadable for HUDView * Create a "Common" group for all files with membership in multiple targets.
* Disable animation on first render, since we'd be animating from a default value so the animation is deceptive. * Use the more specific TimeInterval type for duration
* Enforce a fixed number of fractional digits per unit type. At all times, we prefer: 0 fractional digits for mg/dL 1 fractional digit eliminate the use of significant digits and use fixed a number of fractional digits everywhere. This is in service of: #324 * Pass the glucose NumberFormatter directly into the chart This lets us back out the changes to PredictionTableViewController since now the ChartAxisDoubleUnit uses the glucose formatter to represent its value instead of hardcoding an integer formatter.
…t launch Loop app (#363)
walker0
pushed a commit
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.