eslint

Author: waldbaer

nodes/persistent-value.html

@@ -173,6 +173,7 @@
       const node = this; // Store access to node configuration itself
 
       valueSelectField.on('change', async function() {
+        // eslint-disable-next-line no-invalid-this
         const selected = $(this).find('option:selected');
 
         // Ignore re-population change
@@ -242,6 +243,7 @@
 
       // Initially change triggered by editor loaded, later with every user interaction.
       valuesConfigField.on('change', async function() {
+        // eslint-disable-next-line no-invalid-this
         const selectedConfigId = $(this).val();
 
         if (selectedConfigId !== '_ADD_') { // Skip if "add new config" is selected
@@ -308,25 +310,29 @@
 
       // dynamicControl property
       dynamicControlField.on('change', function() {
+        // eslint-disable-next-line no-invalid-this
         this.checked ? dynamicControlDetails.show() : dynamicControlDetails.hide();
       });
       dynamicCommandMsgPropertyField.typedInput({types: [{label: 'msg.', value: 'str'}]});
       dynamicValueMsgPropertyField.typedInput({types: [{label: 'msg.', value: 'str'}]});
 
       // output Previous Value property
       outputPreviousValueField.on('change', function() {
+        // eslint-disable-next-line no-invalid-this
         this.checked ? outputPreviousValueDetails.show() : outputPreviousValueDetails.hide();
       });
       outputPreviousValueMsgPropertyField.typedInput({types: [{label: 'msg.', value: 'str'}]});
 
       // collectValues property
       collectValuesField.on('change', function() {
+        // eslint-disable-next-line no-invalid-this
         this.checked ? collectValuesDetails.show() : collectValuesDetails.hide();
       });
       collectValuesMsgPropertyField.typedInput({types: [{label: 'msg.', value: 'str'}]});
 
       // block if property
       blockIfEnableField.on('change', function() {
+        // eslint-disable-next-line no-invalid-this
         this.checked ? blockIfDetails.show() : blockIfDetails.hide();
       });
 
@@ -337,6 +343,7 @@
 
       // output MetaData property
       outputMetaDataField.on('change', function() {
+        // eslint-disable-next-line no-invalid-this
         this.checked ? outputMetaDataDetails.show() : outputMetaDataDetails.hide();
       });
       outputMetaDataMsgPropertyField.typedInput({types: [{label: 'msg.', value: 'str'}]});
@@ -699,4 +706,4 @@ <h3>References</h3>
     <ul>
       <li>Node-RED doc <a href="https://nodered.org/docs/user-guide/context">Working with context</a></li>
     </ul>
-</script>
+</script>

nodes/persistent-value.js

@@ -372,8 +372,9 @@ module.exports = function(RED) {
 
   // ---- Node main -------------------------------------------------------------------------------
   RED.nodes.registerType('persistent value', function(nodeConfig) {
-    RED.nodes.createNode(this, nodeConfig);
+    // eslint-disable-next-line no-invalid-this
     const node = this;
+    RED.nodes.createNode(node, nodeConfig);
 
     // ---- Get node settings and referenced config properties ----
 

nodes/persistent-values-config.html

@@ -288,7 +288,7 @@
         height -= 20;
         $('#node-config-input-values-container').editableList('height', height);
       },
-  });
+    });
 })();
 
 </script>

nodes/persistent-values-config.js

@@ -7,13 +7,15 @@ module.exports = function(RED) {
 
   // ---- Node main -------------------------------------------------------------------------------
   RED.nodes.registerType('persistent values config', function(config) {
-    RED.nodes.createNode(this, config);
+    // eslint-disable-next-line no-invalid-this
+    const node = this;
+    RED.nodes.createNode(node, config);
 
-    this.name = config.name;
-    this.values = config.values;
+    node.name = config.name;
+    node.values = config.values;
 
     // Store config in global configs object for HTTP query API.
-    configs[this.id] = {name: config.name, values: config.values};
+    configs[node.id] = {name: config.name, values: config.values};
   });
 
   // https://stackoverflow.com/questions/37265230/node-red-get-configuration-node-value-in-admin-ui

resources/logger.js

@@ -18,4 +18,5 @@
       console.error(`[${LoggerNodeName}] ${message}`);
     }
   };
+// eslint-disable-next-line no-invalid-this
 })(/* istanbul ignore next */ typeof exports === 'undefined' ? this['logger'] = {} : exports);

test/logger_spec.js

@@ -37,8 +37,8 @@ describe('logger utility', function() {
   // ==== Mocks =====
   class NodeMock {
     constructor() {}
-    warn(warn_message, msg = undefined) {}
-    error(error_message, msg = undefined) {}
+    warn(warnMessage, msg = undefined) {}
+    error(errorMessage, msg = undefined) {}
   }
 
   // Mock for a Node-RED node supporting logging

test/persistent_values_config_spec.js

@@ -321,12 +321,11 @@ describe('persistent values config backend node', function() {
       helper.request()
         .get(httpPathGenerateUUID)
         .expect(function(res) {
-          const resp_uuid = res._body;
-          uuid.validate(resp_uuid).should.be.true;
+          const respUuid = res._body;
+          uuid.validate(respUuid).should.be.true;
         })
         .expect(200)
         .end(done);
     });
   });
-
 });