Skip to content

Clone configuration should perform a deep copy #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023
Merged

Clone configuration should perform a deep copy #671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76d9e77
Clone configuration should perform a deep copy
padenot May 10, 2023
052d98c
Address review comment.
padenot May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion index.src.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1764,7 +1764,12 @@
2. If `config[m]` is a nested dictionary, set `clone[m]` to the result of
recursively running the <a>Clone Configuration</a> algorithm with
`config[m]`.
3. Otherwise, assign the value of `config[m]` to `clone[m]`.
3. Otherwise, assign a copy of `config[m]` to `clone[m]`.

Note: This implements a "deep-copy". These configuration objects are
frequently used as the input of asynchronous operations. Copying means that
modifying the original object while the operation is in flight won't change the
operation's outcome.


Signalling Configuration Support{#config-support-info}
Expand Down