From 59489f430bdfa67b43b81326d98e11162fe52bc8 Mon Sep 17 00:00:00 2001 From: Sergey Kanzhelev Date: Mon, 17 Feb 2020 15:33:31 -0800 Subject: [PATCH 1/2] fixed two small bugs --- spec/20-binary-format.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/spec/20-binary-format.md b/spec/20-binary-format.md index 01462f3..30bc055 100644 --- a/spec/20-binary-format.md +++ b/spec/20-binary-format.md @@ -39,8 +39,7 @@ Implementation MUST serialize fields into the field ordering sequence. In other words, `trace-id` field should be serialized first, `parent-id` second and `trace-flags` - third. -Field identifiers should be treated as unsigned byte numbers and should be -encoded in big-endian bit order. +Field identifiers should be treated as unsigned bytes. Fields `trace-id` and `parent-id` are defined as a byte arrays, NOT a long numbers. First element of an array MUST be copied first. When array is @@ -69,7 +68,7 @@ This corresponds to: `{75, 249, 47, 53, 119, 179, 77, 166, 163, 206, 146, 157, 0, 14, 71, 54}` or `4bf92f3577b34da6a3ce929d000e4736`. - `parent-id` is `{52, 240, 103, 170, 11, 169, 2, 183}` or `34f067aa0ba902b7`. -- `trace-flags` is `1` with the meaning `recorded` is true. +- `trace-flags` is `1` with the meaning `sampled` flag is set. ## `tracestate` binary format From 764445e3cc96d8ba8b4f962b0145489ee36e3ba6 Mon Sep 17 00:00:00 2001 From: Sergey Kanzhelev Date: Mon, 17 Feb 2020 15:43:14 -0800 Subject: [PATCH 2/2] few more formatting things --- .vscode/settings.json | 7 +++++++ LICENSE.md | 9 ++++----- ...binary-format-rationale.md => RATIONALE.md | 0 README.md | 19 +++++++++++++------ index.html | 1 - 5 files changed, 24 insertions(+), 12 deletions(-) create mode 100644 .vscode/settings.json rename spec/21-binary-format-rationale.md => RATIONALE.md (100%) diff --git a/.vscode/settings.json b/.vscode/settings.json new file mode 100644 index 0000000..33bb7c5 --- /dev/null +++ b/.vscode/settings.json @@ -0,0 +1,7 @@ +{ + "rewrap.wrappingColumn": [80], + "editor.rulers": [80], + "markdownlint.config": { + "MD013": true + }, +} \ No newline at end of file diff --git a/LICENSE.md b/LICENSE.md index 83eda75..9b3c0aa 100644 --- a/LICENSE.md +++ b/LICENSE.md @@ -1,7 +1,6 @@ -All Reports in this Repository are licensed by contributors -under the +All Reports in this Repository are licensed by contributors under the [W3C Software and Document License](https://www.w3.org/Consortium/Legal/copyright-software). -All tests in this Repository are licensed by contributors to be distributed under the -[W3C 3-clause BSD License](https://www.w3.org/Consortium/Legal/2008/03-bsd-license.html). - +All tests in this Repository are licensed by contributors to be distributed +under the [W3C 3-clause BSD +License](https://www.w3.org/Consortium/Legal/2008/03-bsd-license.html). diff --git a/spec/21-binary-format-rationale.md b/RATIONALE.md similarity index 100% rename from spec/21-binary-format-rationale.md rename to RATIONALE.md diff --git a/README.md b/README.md index 632e971..6519df4 100644 --- a/README.md +++ b/README.md @@ -1,23 +1,30 @@ -[![Build Status](https://img.shields.io/travis/w3c/trace-context-binary/master.svg?label=validation%20service)](./test/) +[![Build Status](https://img.shields.io/travis/w3c/trace-context-binary/master.svg?label=validation%20service)](https://travis-ci.com/w3c/trace-context-binary) # Trace Context: binary protocol Specification -This repository is associated with the [Trace Context: binary protocol](https://w3c.github.io/trace-context-binary/) specification. +This repository is associated with the [Trace Context: binary +protocol](https://w3c.github.io/trace-context-binary/) specification. + +See the [Trace Context Protocols +Registry](https://www.w3.org/TR/trace-context-protocols-registry/) for the list +of all protocols. Specification for distributed tracing context propagation format: - Trace Context: binary protocol [Report](https://w3c.github.io/trace-context-binary/). Status: Editor's draft. - - Changes are tracked on GitHub, communicated in meetings and e-mails - distribution list. +- Changes are tracked on GitHub, communicated in meetings and e-mails + distribution list. +- See [RATIONALE](RATIONALE.md) for considerations of the format. ## Team Communication See [communication](https://github.com/w3c/distributed-tracing-wg#team-communication) -We appreciate feedback and contributions. Please make sure to read rationale documents when you have a question about particular -decision made in specification. +We appreciate feedback and contributions. Please make sure to read rationale +documents when you have a question about particular decision made in +specification. ## Goal diff --git a/index.html b/index.html index 909c6c0..2de1a1e 100644 --- a/index.html +++ b/index.html @@ -38,7 +38,6 @@ wg: "Distributed Tracing Working Group", wgPublicList: "public-trace-context", wgURI: "https://www.w3.org/2018/distributed-tracing/", - //isPreview: true, //this will add ugly box saying it's preview otherLinks: [{ key: 'Discussions', data: [{