Editorial: fix 'in parallel' usage #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hiding whitespace makes this easier to review: |
reillyeon
requested changes
Sep 21, 2022
| implementation. User agents MAY impose a rate limit on how | ||
| frequently position changes are reported. | ||
| </li> | ||
| <li>If |document| is not [=Document/fully active=] or |
Member
There was a problem hiding this comment.
Can we check this while "in parallel"? If not then we should do a larger rewrite (perhaps in a follow-up to reduce churn) to only go "in parallel" for specifically the requesting permission and acquiring a position steps.
Member
Author
There was a problem hiding this comment.
yeah, good point. We should probably just queue a global task here that can then check the state of the document sync.
Co-authored-by: Reilly Grant <[email protected]>
reillyeon
approved these changes
Sep 21, 2022
Member
reillyeon
left a comment
reillyeon
left a comment
There was a problem hiding this comment.
This looks good as an incremental step.
Member
|
Please resolve the merge conflicts and I will merge this change. |
Member
Author
|
Fixed! thanks for the speedy review! |
reillyeon
approved these changes
Sep 23, 2022
github-actions bot
added a commit
that referenced
this pull request
Sep 23, 2022
SHA: a95f47a Reason: push, by @reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
4 tasks
himorin
added a commit
to himorin/w3c-spec-geolocation
that referenced
this pull request
Sep 22, 2025
marcoscaceres
pushed a commit
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126
Preview | Diff