feat(theme): add LoadWhenVisible component and lazyload footer #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
force-pushed
the
M2-181-make-app-footer-lazy-loaded
branch
from
92dde94 to
bb534cd
Compare
Frodigo
suggested changes
Feb 18, 2022
| let observer = null; | ||
| if (process.browser && ('IntersectionObserver' in window)) { | ||
| observer = new IntersectionObserver((entries) => { |
Contributor
There was a problem hiding this comment.
Could you add the rootMargin prop and bind it to IntersectionObserver initialization?
| </div> | ||
| <BottomNavigation /> | ||
| <AppFooter /> | ||
| <LoadWhenVisible> |
Contributor
There was a problem hiding this comment.
When you add rootMargin option, please set up it here. Please try 100px 0 0 0.
Thanks to that footer should be shown a little bit earlier, and UX will be better.
- update social icons to reduce weight and increase quality - load footer only when visible
bartoszherba
force-pushed
the
M2-181-make-app-footer-lazy-loaded
branch
from
bb534cd to
83ccb19
Compare
Frodigo
approved these changes
Feb 18, 2022
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Refactoring and performance improvement
How Has This Been Tested?
Observe networking if the footer is loaded only when visible
Screenshots (if appropriate):
Types of changes
Checklist: