fix: broken cart after placing order as guest (#386)

* fix(theme): passing the email instead of the user-object for creating a guest-cart

* fix(composables): remove empty params in array, fails on Magento

* test(theme): updated test for attaching guest email address to cart

* Update packages/composables/src/composables/useShipping/index.ts

Co-authored-by: Heitor Ramon Ribeiro <[email protected]>

Co-authored-by: Marcin Kwiatkowski <[email protected]>
Co-authored-by: Heitor Ramon Ribeiro <[email protected]>

Author: 3 people

packages/composables/src/composables/useBilling/index.ts

@@ -49,7 +49,7 @@ const factoryParams: UseBillingParams<any, any> = {
       : ({
         address: {
           ...address,
-          street: [address.street, apartment, neighborhood, extra],
+          street: [address.street, apartment, neighborhood, extra].filter(Boolean),
         },
         same_as_shipping: sameAsShipping,
       });

packages/composables/src/composables/useShipping/index.ts

@@ -49,7 +49,7 @@ const factoryParams: UseShippingParams<any, any> = {
       : ({
         address: {
           ...address,
-          street: [address.street, apartment, neighborhood, extra],
+          street: [address.street, apartment, neighborhood, extra].filter(Boolean),
         },
       });
 

packages/theme/pages/Checkout/UserAccount.vue

@@ -218,7 +218,7 @@ export default defineComponent({
       if (!isAuthenticated.value) {
         await (
           !createUserAccount.value
-            ? attachToCart({ user: form.value })
+            ? attachToCart({ email: form.value.email })
             : register({ user: form.value })
         );
       }

packages/theme/pages/Checkout/__tests__/UserAccount.spec.js

@@ -94,13 +94,7 @@ describe('<UserAccount/>', () => {
     await waitFor(() => {
       expect(attachToCartMock).toHaveBeenCalledTimes(1);
       expect(attachToCartMock).toHaveBeenCalledWith({
-        user: {
-          email: '[email protected]',
-          firstname: 'James',
-          lastname: 'Bond',
-          password: '',
-          is_subscribed: false,
-        },
+        email: '[email protected]',
       });
     });
     expect(routerPushMock).toHaveBeenCalledTimes(1);