Skip to content

Commit 775b026

Browse files
committed
ci: run lint in build
this is necessary because typescript-eslint requires packages to be built to check for errors
1 parent 05d9146 commit 775b026

File tree

3 files changed

+8
-27
lines changed

3 files changed

+8
-27
lines changed

.github/workflows/eslint.yml

Lines changed: 0 additions & 25 deletions
This file was deleted.

.github/workflows/test.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,10 @@ jobs:
3636
- name: Build packages
3737
run: yarn build
3838

39+
# typescript-eslint needs all packages to be built
40+
# to check type-related linting rules
41+
- name: Check for linting errors
42+
run: yarn lint
43+
3944
- name: Test theme
4045
run: yarn test:theme

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
"internals/*"
1212
],
1313
"scripts": {
14-
"build": "yarn build:api-client && yarn build:theme",
14+
"build": "yarn build:api-client && yarn build:theme && yarn build:composables",
1515
"build:api-client": "cd packages/api-client && yarn build",
1616
"build:theme": "cd packages/theme && yarn build",
17+
"build:composables": "cd packages/composables && yarn build",
1718
"contributors:add": "all-contributors add",
1819
"contributors:generate": "all-contributors generate",
1920
"dev:api-client": "cd packages/api-client && yarn dev",
@@ -22,7 +23,7 @@
2223
"docs:dev": "cd docs && yarn dev",
2324
"docs:build": "cd docs && yarn build",
2425
"graphql:codegen": "graphql-codegen --config codegen.yml",
25-
"lint": "eslint . --ext .ts,.vue --fix",
26+
"lint": "eslint .",
2627
"prepare": "[ -d '.husky' ] && (husky install && shx rm -rf .git/hooks && shx ln -s ../.husky .git/hooks) || true",
2728
"publish:api-client": "node ./scripts/publishApi.js",
2829
"start": "cd packages/theme && yarn start",

0 commit comments

Comments
 (0)