Skip to content

Commit 3f06fd6

Browse files
committed
refactor(theme): change to new refactored usereview composable
1 parent 455e008 commit 3f06fd6

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

packages/theme/components/ProductAddReviewForm.vue

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,7 @@ import {
120120
useRoute,
121121
useContext,
122122
} from '@nuxtjs/composition-api';
123-
import {
124-
reviewGetters, useReview, userGetters,
125-
} from '@vue-storefront/magento';
123+
import { reviewGetters, userGetters } from '@vue-storefront/magento';
126124
import { extend, ValidationObserver, ValidationProvider } from 'vee-validate';
127125
import { min, oneOf, required } from 'vee-validate/dist/rules';
128126
import {
@@ -132,6 +130,7 @@ import {
132130
SfTextarea,
133131
} from '@storefront-ui/vue';
134132
import { useUser } from '~/composables';
133+
import { useReview } from '~/composables/useReview';
135134
136135
extend('required', {
137136
...required,

packages/theme/components/__tests__/ProductAddReviewForm.spec.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,21 @@
22
import { waitFor } from '@testing-library/vue';
33
import userEvent from '@testing-library/user-event';
44
import { useRoute } from '@nuxtjs/composition-api';
5-
import { useUser, useReview } from '@vue-storefront/magento';
5+
import { useUser } from '@vue-storefront/magento';
66
import {
77
render,
88
useUserMock,
99
useReviewMock,
1010
} from '~/test-utils';
1111

1212
import ProductAddReviewForm from '../ProductAddReviewForm';
13+
import { useReview } from '~/composables/useReview';
1314

1415
jest.mock('@vue-storefront/magento', () => {
1516
const originalModule = jest.requireActual('@vue-storefront/magento');
1617
return {
1718
...originalModule,
1819
useUser: jest.fn(),
19-
useReview: jest.fn(),
2020
};
2121
});
2222

@@ -30,6 +30,14 @@ jest.mock('@nuxtjs/composition-api', () => {
3030
};
3131
});
3232

33+
jest.mock('~/composables/useReview', () => {
34+
const originalModule = jest.requireActual('~/composables/useReview');
35+
return {
36+
...originalModule,
37+
useReview: jest.fn(),
38+
};
39+
});
40+
3341
describe.skip('<ProductAddReviewForm/>', () => {
3442
it('Form fields are rendered and validated', async () => {
3543
useUser.mockReturnValue(useUserMock());

packages/theme/pages/MyAccount/MyReviews.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,9 @@ import {
5858
SfReview,
5959
SfRating,
6060
} from '@storefront-ui/vue';
61-
import { reviewGetters, useReview } from '@vue-storefront/magento';
61+
import { reviewGetters } from '@vue-storefront/magento';
6262
import { computed, defineComponent, onMounted } from '@nuxtjs/composition-api';
63+
import { useReview } from '~/composables/useReview';
6364
6465
export default defineComponent({
6566
name: 'MyReviews',

packages/theme/pages/Product.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,6 @@ import {
269269
} from '@storefront-ui/vue';
270270
import {
271271
productGetters,
272-
useReview,
273272
reviewGetters,
274273
} from '@vue-storefront/magento';
275274
import {
@@ -296,6 +295,7 @@ import UpsellProducts from '~/components/UpsellProducts';
296295
import RelatedProducts from '~/components/RelatedProducts';
297296
import HTMLContent from '~/components/HTMLContent';
298297
import AddToWishlist from '~/components/AddToWishlist';
298+
import { useReview } from '~/composables/useReview';
299299
300300
export default defineComponent({
301301
name: 'ProductPage',

0 commit comments

Comments
 (0)