refactor: remove category getters call from app header

- apply suggestions from code review

Co-authored-by: Artur Tagisow <[email protected]>

Author: bartoszherba

packages/theme/components/AppHeader.vue

@@ -183,17 +183,13 @@ export default defineComponent({
     useFetch(async () => {
       await categoriesListLoad({ pageSize: 20 });
 
-      function prepareMenuData() {
-        return categoryList.value?.[0]?.children
-          .map((category) => ({
-            includeInMenu: category.include_in_menu,
-            label: category.name,
-            slug: `/${category.url_path}${category.url_suffix}`,
-          }))
-          .filter((category) => category.includeInMenu) ?? [];
-      }
-
-      categoryTree.value = prepareMenuData();
+      categoryTree.value = categoryList.value?.[0]?.children
+        .filter((category) => category.include_in_menu)
+        .map((category) => ({
+          includeInMenu: category.include_in_menu,
+          label: category.name,
+          slug: `/${category.url_path}${category.url_suffix}`,
+        })) ?? [];
     });
 
     onMounted(() => {

packages/theme/helpers/product/productData.ts

@@ -8,7 +8,7 @@ export const productData = (products) => {
     id,
     product: computed(() => {
       if (!products) return {};
-      return Array.isArray(products.value?.items) && products.value?.items[0] ? products.value?.items[0] : [];
+      return products.value?.items?.[0] ?? [];
     }),
   };
 };

packages/theme/pages/Home.vue

@@ -106,7 +106,6 @@ import {
 } from '@nuxtjs/composition-api';
 import LazyHydrate from 'vue-lazy-hydration';
 import { useCache, CacheTagPrefix } from '@vue-storefront/cache';
-import { productGetters } from '~/getters';
 import { useProduct } from '~/composables';
 import MobileStoreBanner from '~/components/MobileStoreBanner.vue';
 import InstagramFeed from '~/components/InstagramFeed.vue';
@@ -241,7 +240,7 @@ export default defineComponent({
     ]);
 
     onMounted(async () => {
-      const productsData = await getProductList({
+      newProducts.value = await getProductList({
         pageSize: 10,
         currentPage: 1,
         sort: {
@@ -250,8 +249,6 @@ export default defineComponent({
       });
 
       addTags([{ prefix: CacheTagPrefix.View, value: 'home' }]);
-
-      newProducts.value = productsData?.items;
     });
 
     // @ts-ignore
@@ -260,7 +257,6 @@ export default defineComponent({
       heroes,
       newProducts,
       newProductsLoading,
-      productGetters,
     };
   },
 });