Skip to content

Commit 2b00372

Browse files
authored
fix(theme): fix flashing category page (#388)
Co-authored-by: Bartosz Herba <[email protected]>
1 parent d9334a5 commit 2b00372

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

packages/theme/pages/Category.vue

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
:value="sortBy.selected"
4040
placeholder="Select sorting"
4141
class="navbar__select"
42-
@input="th.changeSorting"
42+
@input="uiHelpers.changeSorting"
4343
>
4444
<SfSelectOption
4545
v-for="option in sortBy.options"
@@ -214,7 +214,7 @@
214214
<SfSelect
215215
:value="pagination.itemsPerPage.toString()"
216216
class="products__items-per-page"
217-
@input="th.changeItemsPerPage"
217+
@input="uiHelpers.changeItemsPerPage"
218218
>
219219
<SfSelectOption
220220
v-for="option in pagination.pageOptions"
@@ -250,7 +250,7 @@
250250
class="filters__title sf-heading--left"
251251
/>
252252
<div
253-
v-if="isFacetColor(facet)"
253+
v-if="uiHelpers.isFacetColor(facet)"
254254
:key="`${facet.id}-colors`"
255255
class="filters__colors"
256256
>
@@ -397,7 +397,7 @@ export default defineComponent({
397397
}),
398398
transition: 'fade',
399399
setup() {
400-
const th = useUiHelpers();
400+
const uiHelpers = useUiHelpers();
401401
const uiState = useUiState();
402402
const {
403403
path,
@@ -415,17 +415,11 @@ export default defineComponent({
415415
const {
416416
result,
417417
search,
418-
loading,
419418
} = useFacet(`facetId:${path}`);
420-
const {
421-
changeFilters,
422-
isFacetColor,
423-
} = useUiHelpers();
424419
const { toggleFilterSidebar } = useUiState();
425420
const {
426421
categories,
427422
search: categoriesSearch,
428-
loading: categoriesLoading,
429423
} = useCategory(`categoryList:${path}`);
430424
const {
431425
addItemToCart,
@@ -519,7 +513,7 @@ export default defineComponent({
519513
selectedFilters.value = filters;
520514
}
521515
522-
changeFilters(selectedFilters.value);
516+
uiHelpers.changeFilters(selectedFilters.value);
523517
};
524518
525519
const addItemToWishlist = async (product) => {
@@ -535,7 +529,7 @@ export default defineComponent({
535529
? activeCategoryUid(routeData.value?.entity_uid)
536530
: routeData.value?.entity_uid;
537531
await search({
538-
...th.getFacetsFromURL(),
532+
...uiHelpers.getFacetsFromURL(),
539533
categoryId,
540534
});
541535
};
@@ -581,11 +575,9 @@ export default defineComponent({
581575
applyFilters,
582576
breadcrumbs,
583577
categories,
584-
categoriesLoading,
585578
categoryTree,
586579
facets,
587580
isAuthenticated,
588-
isFacetColor,
589581
isFilterSelected,
590582
isInCart,
591583
isInWishlist,
@@ -596,7 +588,7 @@ export default defineComponent({
596588
selectedFilters,
597589
selectFilter,
598590
sortBy,
599-
th,
591+
uiHelpers,
600592
};
601593
},
602594
});

0 commit comments

Comments
 (0)