From 57cb8c67eeb5931ee7b47e3d5e0e5aa09d6a360f Mon Sep 17 00:00:00 2001 From: Guillaume Briday Date: Fri, 14 Sep 2018 10:49:23 +0200 Subject: [PATCH 1/3] Adding default array example of correct rule --- docs/rules/require-valid-default-prop.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/rules/require-valid-default-prop.md b/docs/rules/require-valid-default-prop.md index 2049534b4..398ac01ec 100644 --- a/docs/rules/require-valid-default-prop.md +++ b/docs/rules/require-valid-default-prop.md @@ -42,6 +42,10 @@ props: { // multiple possible types propB: [String, Number], // a number with default value + propC: { + type: Array, + default: () => [] + }, propD: { type: Number, default: 100 From 311bfb13f7e6947d77a03a2df44ae6557681c830 Mon Sep 17 00:00:00 2001 From: Guillaume Briday Date: Tue, 18 Sep 2018 21:23:30 -0700 Subject: [PATCH 2/3] Updating examples for factory functions --- docs/rules/require-valid-default-prop.md | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/docs/rules/require-valid-default-prop.md b/docs/rules/require-valid-default-prop.md index 398ac01ec..a6e979625 100644 --- a/docs/rules/require-valid-default-prop.md +++ b/docs/rules/require-valid-default-prop.md @@ -42,10 +42,6 @@ props: { // multiple possible types propB: [String, Number], // a number with default value - propC: { - type: Array, - default: () => [] - }, propD: { type: Number, default: 100 @@ -53,10 +49,12 @@ props: { // object/array defaults should be returned from a factory function propE: { type: Object, - default: function () { - return { message: 'hello' } - } - } + default: () => { message: 'hello' } + }, + propF: { + type: Array, + default: () => [] + } } ``` From 9a83eed16096b33adc969f0c0b1cfc612d06cd49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Sajn=C3=B3g?= Date: Fri, 28 Sep 2018 18:55:38 +0100 Subject: [PATCH 3/3] Update require-valid-default-prop.md --- docs/rules/require-valid-default-prop.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/rules/require-valid-default-prop.md b/docs/rules/require-valid-default-prop.md index a6e979625..eee9692ce 100644 --- a/docs/rules/require-valid-default-prop.md +++ b/docs/rules/require-valid-default-prop.md @@ -49,11 +49,15 @@ props: { // object/array defaults should be returned from a factory function propE: { type: Object, - default: () => { message: 'hello' } + default() { + return { message: 'hello' } + } }, propF: { type: Array, - default: () => [] + default() { + return [] + } } } ```