From 1e300db109d086b30431e0a18f6cbbc23698dcc6 Mon Sep 17 00:00:00 2001
From: Toru Nagashima <star.ctor@gmail.com>
Date: Thu, 22 Jun 2017 12:47:50 +0900
Subject: [PATCH 1/6] Fix: `no-invalid-template-root` has false positive about
 empty templates (fixes #41)

---
 lib/rules/no-invalid-template-root.js       | 14 -----------
 tests/lib/rules/no-invalid-template-root.js | 27 +++++++++------------
 2 files changed, 12 insertions(+), 29 deletions(-)

diff --git a/lib/rules/no-invalid-template-root.js b/lib/rules/no-invalid-template-root.js
index 8b34dacf9..ddebaedfd 100644
--- a/lib/rules/no-invalid-template-root.js
+++ b/lib/rules/no-invalid-template-root.js
@@ -65,12 +65,6 @@ function create (context) {
           loc: extraElement.loc,
           message: 'The template root requires exactly one element.'
         })
-      } else if (rootElements.length === 0) {
-        context.report({
-          node,
-          loc: node.loc,
-          message: 'The template root requires exactly one element.'
-        })
       } else {
         for (const element of rootElements) {
           const tag = element.startTag
@@ -92,14 +86,6 @@ function create (context) {
             })
           }
         }
-        if (vIf) {
-          const tag = rootElements[0].startTag
-          context.report({
-            node: tag,
-            loc: tag.loc,
-            message: "The template root requires the next element which has 'v-else' directives if it has 'v-if' directives."
-          })
-        }
       }
     }
   }
diff --git a/tests/lib/rules/no-invalid-template-root.js b/tests/lib/rules/no-invalid-template-root.js
index 89a38c7b8..322ac67dc 100644
--- a/tests/lib/rules/no-invalid-template-root.js
+++ b/tests/lib/rules/no-invalid-template-root.js
@@ -50,14 +50,21 @@ tester.run('no-invalid-template-root', rule, {
     {
       filename: 'test.vue',
       code: `<template>\n    <c1 v-if="1" />\n    <c2 v-else-if="1" />\n    <c3 v-else />\n</template>`
-    }
-  ],
-  invalid: [
+    },
     {
       filename: 'test.vue',
-      code: '<template>\n</template>',
-      errors: ['The template root requires exactly one element.']
+      code: '<template>\n</template>'
     },
+    {
+      filename: 'test.vue',
+      code: '<template><div v-if="foo"></div></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div v-if="foo"></div><div v-else-if="bar"></div></template>'
+    }
+  ],
+  invalid: [
     {
       filename: 'test.vue',
       code: '<template><div></div><div></div></template>',
@@ -88,16 +95,6 @@ tester.run('no-invalid-template-root', rule, {
       code: '<template><div v-for="x in list"></div></template>',
       errors: ["The template root disallows 'v-for' directives."]
     },
-    {
-      filename: 'test.vue',
-      code: '<template><div v-if="foo"></div></template>',
-      errors: ["The template root requires the next element which has 'v-else' directives if it has 'v-if' directives."]
-    },
-    {
-      filename: 'test.vue',
-      code: '<template><div v-if="foo"></div><div v-else-if="bar"></div></template>',
-      errors: ["The template root requires the next element which has 'v-else' directives if it has 'v-if' directives."]
-    },
     {
       filename: 'test.vue',
       code: '<template><slot></slot></template>',

From f220c0d6804a52e948a23c18b42b93325ef705de Mon Sep 17 00:00:00 2001
From: Toru Nagashima <star.ctor@gmail.com>
Date: Sun, 25 Jun 2017 03:04:53 +0900
Subject: [PATCH 2/6] revive warnings of empty

---
 lib/rules/no-invalid-template-root.js       | 6 ++++++
 tests/lib/rules/no-invalid-template-root.js | 9 +++++----
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/lib/rules/no-invalid-template-root.js b/lib/rules/no-invalid-template-root.js
index ddebaedfd..f4f891a30 100644
--- a/lib/rules/no-invalid-template-root.js
+++ b/lib/rules/no-invalid-template-root.js
@@ -65,6 +65,12 @@ function create (context) {
           loc: extraElement.loc,
           message: 'The template root requires exactly one element.'
         })
+      } else if (rootElements.length === 0) {
+        context.report({
+          node,
+          loc: node.loc,
+          message: 'The template root requires exactly one element.'
+        })
       } else {
         for (const element of rootElements) {
           const tag = element.startTag
diff --git a/tests/lib/rules/no-invalid-template-root.js b/tests/lib/rules/no-invalid-template-root.js
index 322ac67dc..d5b311515 100644
--- a/tests/lib/rules/no-invalid-template-root.js
+++ b/tests/lib/rules/no-invalid-template-root.js
@@ -51,10 +51,6 @@ tester.run('no-invalid-template-root', rule, {
       filename: 'test.vue',
       code: `<template>\n    <c1 v-if="1" />\n    <c2 v-else-if="1" />\n    <c3 v-else />\n</template>`
     },
-    {
-      filename: 'test.vue',
-      code: '<template>\n</template>'
-    },
     {
       filename: 'test.vue',
       code: '<template><div v-if="foo"></div></template>'
@@ -65,6 +61,11 @@ tester.run('no-invalid-template-root', rule, {
     }
   ],
   invalid: [
+    {
+      filename: 'test.vue',
+      code: '<template>\n</template>',
+      errors: ['The template root requires exactly one element.']
+    },
     {
       filename: 'test.vue',
       code: '<template><div></div><div></div></template>',

From d8dd93d7c30560b1a6490e45edda98ba91b77597 Mon Sep 17 00:00:00 2001
From: Toru Nagashima <star.ctor@gmail.com>
Date: Sun, 25 Jun 2017 03:19:38 +0900
Subject: [PATCH 3/6] update docs

---
 docs/rules/no-invalid-template-root.md | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/docs/rules/no-invalid-template-root.md b/docs/rules/no-invalid-template-root.md
index aa8c40d43..8f96ea094 100644
--- a/docs/rules/no-invalid-template-root.md
+++ b/docs/rules/no-invalid-template-root.md
@@ -6,14 +6,19 @@ This rule checks whether every template root is valid.
 
 This rule reports the template root if the following cases:
 
+- The root is nothing. E.g. `<template></template>`.
 - The root is text. E.g. `<template>hello</template>`.
 - The root is multiple elements. E.g. `<template><div>one</div><div>two</div></template>`.
 - The root element has `v-for` directives. E.g. `<template><div v-for="x in list">{{x}}</div></template>`.
-- The root element has `v-if`/`v-else-if` directives without `v-else` elements. E.g. `<template><div v-if="foo">hello</div></template>`.
 - The root element is `<template>` or `<slot>` elements. E.g. `<template><template>hello</template></template>`.
 
 👎 Examples of **incorrect** code for this rule:
 
+```html
+<template>
+</template>
+```
+
 ```html
 <template>
     <div>hello</div>
@@ -33,17 +38,17 @@ This rule reports the template root if the following cases:
 </template>
 ```
 
+👍 Examples of **correct** code for this rule:
+
 ```html
 <template>
-    <div v-if="foo"></div>
+    <div>abc</div>
 </template>
 ```
 
-👍 Examples of **correct** code for this rule:
-
 ```html
 <template>
-    <div>abc</div>
+    <div v-if="foo"></div>
 </template>
 ```
 

From 9e029b226b5c5c2de99ead37b39bb20c90dd98bb Mon Sep 17 00:00:00 2001
From: Toru Nagashima <star.ctor@gmail.com>
Date: Sun, 25 Jun 2017 03:10:14 +0900
Subject: [PATCH 4/6] fix for src attributes

---
 lib/rules/no-invalid-template-root.js       | 13 ++++++++++---
 tests/lib/rules/no-invalid-template-root.js | 14 ++++++++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/lib/rules/no-invalid-template-root.js b/lib/rules/no-invalid-template-root.js
index f4f891a30..fc567b862 100644
--- a/lib/rules/no-invalid-template-root.js
+++ b/lib/rules/no-invalid-template-root.js
@@ -31,13 +31,14 @@ function create (context) {
         return
       }
 
+      const hasSrc = utils.hasAttribute(node.startTag, 'src')
       const rootElements = []
       let extraText = null
       let extraElement = null
       let vIf = false
       for (const child of node.children) {
         if (child.type === 'VElement') {
-          if (rootElements.length === 0) {
+          if (rootElements.length === 0 && !hasSrc) {
             rootElements.push(child)
             vIf = utils.hasDirective(child.startTag, 'if')
           } else if (vIf && utils.hasDirective(child.startTag, 'else-if')) {
@@ -53,7 +54,13 @@ function create (context) {
         }
       }
 
-      if (extraText != null) {
+      if (hasSrc && (extraText != null || extraElement != null)) {
+        context.report({
+          node: extraText || extraElement,
+          loc: (extraText || extraElement).loc,
+          message: "The template root which has 'src' attribute requires empty."
+        })
+      } else if (extraText != null) {
         context.report({
           node: extraText,
           loc: extraText.loc,
@@ -65,7 +72,7 @@ function create (context) {
           loc: extraElement.loc,
           message: 'The template root requires exactly one element.'
         })
-      } else if (rootElements.length === 0) {
+      } else if (rootElements.length === 0 && !hasSrc) {
         context.report({
           node,
           loc: node.loc,
diff --git a/tests/lib/rules/no-invalid-template-root.js b/tests/lib/rules/no-invalid-template-root.js
index d5b311515..bb9827d71 100644
--- a/tests/lib/rules/no-invalid-template-root.js
+++ b/tests/lib/rules/no-invalid-template-root.js
@@ -58,6 +58,10 @@ tester.run('no-invalid-template-root', rule, {
     {
       filename: 'test.vue',
       code: '<template><div v-if="foo"></div><div v-else-if="bar"></div></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template src="foo.html"></template>'
     }
   ],
   invalid: [
@@ -105,6 +109,16 @@ tester.run('no-invalid-template-root', rule, {
       filename: 'test.vue',
       code: '<template><template></template></template>',
       errors: ["The template root disallows '<template>' elements."]
+    },
+    {
+      filename: 'test.vue',
+      code: '<template src="foo.html">abc</template>',
+      errors: ["The template root which has 'src' attribute requires empty."]
+    },
+    {
+      filename: 'test.vue',
+      code: '<template src="foo.html"><div></div></template>',
+      errors: ["The template root which has 'src' attribute requires empty."]
     }
   ]
 })

From b898441c7d6a73322fdcf913603b5b3243be3cb0 Mon Sep 17 00:00:00 2001
From: Toru Nagashima <star.ctor@gmail.com>
Date: Tue, 27 Jun 2017 19:49:11 +0900
Subject: [PATCH 5/6] fix error message

---
 lib/rules/no-invalid-template-root.js       | 2 +-
 tests/lib/rules/no-invalid-template-root.js | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/rules/no-invalid-template-root.js b/lib/rules/no-invalid-template-root.js
index fc567b862..17f73cb87 100644
--- a/lib/rules/no-invalid-template-root.js
+++ b/lib/rules/no-invalid-template-root.js
@@ -58,7 +58,7 @@ function create (context) {
         context.report({
           node: extraText || extraElement,
           loc: (extraText || extraElement).loc,
-          message: "The template root which has 'src' attribute requires empty."
+          message: "The template root with 'src' attribute is required to be empty."
         })
       } else if (extraText != null) {
         context.report({
diff --git a/tests/lib/rules/no-invalid-template-root.js b/tests/lib/rules/no-invalid-template-root.js
index bb9827d71..cc4979fcc 100644
--- a/tests/lib/rules/no-invalid-template-root.js
+++ b/tests/lib/rules/no-invalid-template-root.js
@@ -113,12 +113,12 @@ tester.run('no-invalid-template-root', rule, {
     {
       filename: 'test.vue',
       code: '<template src="foo.html">abc</template>',
-      errors: ["The template root which has 'src' attribute requires empty."]
+      errors: ["The template root with 'src' attribute is required to be empty."]
     },
     {
       filename: 'test.vue',
       code: '<template src="foo.html"><div></div></template>',
-      errors: ["The template root which has 'src' attribute requires empty."]
+      errors: ["The template root with 'src' attribute is required to be empty."]
     }
   ]
 })

From f991230feb651f8c2f12c645100dbdda3fd20f42 Mon Sep 17 00:00:00 2001
From: Toru Nagashima <star.ctor@gmail.com>
Date: Tue, 27 Jun 2017 19:49:35 +0900
Subject: [PATCH 6/6] =?UTF-8?q?`if`=20=E2=86=92=20`in`?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 docs/rules/no-confusing-v-for-v-if.md  | 2 +-
 docs/rules/no-invalid-template-root.md | 2 +-
 docs/rules/no-invalid-v-bind.md        | 2 +-
 docs/rules/no-invalid-v-cloak.md       | 2 +-
 docs/rules/no-invalid-v-else-if.md     | 2 +-
 docs/rules/no-invalid-v-else.md        | 2 +-
 docs/rules/no-invalid-v-for.md         | 2 +-
 docs/rules/no-invalid-v-html.md        | 2 +-
 docs/rules/no-invalid-v-if.md          | 2 +-
 docs/rules/no-invalid-v-model.md       | 2 +-
 docs/rules/no-invalid-v-on.md          | 2 +-
 docs/rules/no-invalid-v-once.md        | 2 +-
 docs/rules/no-invalid-v-pre.md         | 2 +-
 docs/rules/no-invalid-v-show.md        | 2 +-
 docs/rules/no-invalid-v-text.md        | 2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/docs/rules/no-confusing-v-for-v-if.md b/docs/rules/no-confusing-v-for-v-if.md
index aff05acdc..3415520e8 100644
--- a/docs/rules/no-confusing-v-for-v-if.md
+++ b/docs/rules/no-confusing-v-for-v-if.md
@@ -8,7 +8,7 @@ So when they exist on the same node, `v-if` directive should use the reference w
 
 ## 📖 Rule Details
 
-This rule reports the elements which have both `v-for` and `v-if` directives if the following cases:
+This rule reports the elements which have both `v-for` and `v-if` directives in the following cases:
 
 - The `v-if` directive does not use the reference which is to the variables which are defined by the `v-for` directives.
 
diff --git a/docs/rules/no-invalid-template-root.md b/docs/rules/no-invalid-template-root.md
index 8f96ea094..15f4a6d6e 100644
--- a/docs/rules/no-invalid-template-root.md
+++ b/docs/rules/no-invalid-template-root.md
@@ -4,7 +4,7 @@ This rule checks whether every template root is valid.
 
 ## 📖 Rule Details
 
-This rule reports the template root if the following cases:
+This rule reports the template root in the following cases:
 
 - The root is nothing. E.g. `<template></template>`.
 - The root is text. E.g. `<template>hello</template>`.
diff --git a/docs/rules/no-invalid-v-bind.md b/docs/rules/no-invalid-v-bind.md
index 2815096f5..c9c2b8c64 100644
--- a/docs/rules/no-invalid-v-bind.md
+++ b/docs/rules/no-invalid-v-bind.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-bind` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-bind` directives if the following cases:
+This rule reports `v-bind` directives in the following cases:
 
 - The directive does not have that attribute value. E.g. `<div v-bind:aaa></div>`
 - The directive has invalid modifiers. E.g. `<div v-bind:aaa.bbb="ccc"></div>`
diff --git a/docs/rules/no-invalid-v-cloak.md b/docs/rules/no-invalid-v-cloak.md
index ed6e34c36..cf8f68045 100644
--- a/docs/rules/no-invalid-v-cloak.md
+++ b/docs/rules/no-invalid-v-cloak.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-cloak` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-cloak` directives if the following cases:
+This rule reports `v-cloak` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-cloak:aaa></div>`
 - The directive has that modifier. E.g. `<div v-cloak.bbb></div>`
diff --git a/docs/rules/no-invalid-v-else-if.md b/docs/rules/no-invalid-v-else-if.md
index 53e49df3c..7876a1a99 100644
--- a/docs/rules/no-invalid-v-else-if.md
+++ b/docs/rules/no-invalid-v-else-if.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-else-if` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-else-if` directives if the following cases:
+This rule reports `v-else-if` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-if="foo"></div><div v-else-if:aaa="bar"></div>`
 - The directive has that modifier. E.g. `<div v-if="foo"></div><div v-else-if.bbb="bar"></div>`
diff --git a/docs/rules/no-invalid-v-else.md b/docs/rules/no-invalid-v-else.md
index 6ca238d47..530c57696 100644
--- a/docs/rules/no-invalid-v-else.md
+++ b/docs/rules/no-invalid-v-else.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-else` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-else` directives if the following cases:
+This rule reports `v-else` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-if="foo"></div><div v-else:aaa></div>`
 - The directive has that modifier. E.g. `<div v-if="foo"></div><div v-else.bbb></div>`
diff --git a/docs/rules/no-invalid-v-for.md b/docs/rules/no-invalid-v-for.md
index 820811e19..5dc6619b2 100644
--- a/docs/rules/no-invalid-v-for.md
+++ b/docs/rules/no-invalid-v-for.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-for` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-for` directives if the following cases:
+This rule reports `v-for` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-for:aaa></div>`
 - The directive has that modifier. E.g. `<div v-for.bbb></div>`
diff --git a/docs/rules/no-invalid-v-html.md b/docs/rules/no-invalid-v-html.md
index 573bdba89..5998861ca 100644
--- a/docs/rules/no-invalid-v-html.md
+++ b/docs/rules/no-invalid-v-html.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-html` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-html` directives if the following cases:
+This rule reports `v-html` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-html:aaa></div>`
 - The directive has that modifier. E.g. `<div v-html.bbb></div>`
diff --git a/docs/rules/no-invalid-v-if.md b/docs/rules/no-invalid-v-if.md
index 330ef0bb5..f746e9332 100644
--- a/docs/rules/no-invalid-v-if.md
+++ b/docs/rules/no-invalid-v-if.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-if` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-if` directives if the following cases:
+This rule reports `v-if` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-if:aaa="foo"></div>`
 - The directive has that modifier. E.g. `<div v-if.bbb="foo"></div>`
diff --git a/docs/rules/no-invalid-v-model.md b/docs/rules/no-invalid-v-model.md
index de5adcfe2..e7ab254d8 100644
--- a/docs/rules/no-invalid-v-model.md
+++ b/docs/rules/no-invalid-v-model.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-model` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-model` directives if the following cases:
+This rule reports `v-model` directives in the following cases:
 
 - The directive has that argument. E.g. `<input v-model:aaa="foo">`
 - The directive has the modifiers which are not supported. E.g. `<input v-model.bbb="foo">`
diff --git a/docs/rules/no-invalid-v-on.md b/docs/rules/no-invalid-v-on.md
index 38da1e6e6..0076bdd1c 100644
--- a/docs/rules/no-invalid-v-on.md
+++ b/docs/rules/no-invalid-v-on.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-on` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-on` directives if the following cases:
+This rule reports `v-on` directives in the following cases:
 
 - The directive does not have that event name. E.g. `<div v-on="foo"></div>`
 - The directive has invalid modifiers. E.g. `<div v-on:click.bbb="foo"></div>`
diff --git a/docs/rules/no-invalid-v-once.md b/docs/rules/no-invalid-v-once.md
index 8f5ab7b13..852d6fadd 100644
--- a/docs/rules/no-invalid-v-once.md
+++ b/docs/rules/no-invalid-v-once.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-once` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-once` directives if the following cases:
+This rule reports `v-once` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-once:aaa></div>`
 - The directive has that modifier. E.g. `<div v-once.bbb></div>`
diff --git a/docs/rules/no-invalid-v-pre.md b/docs/rules/no-invalid-v-pre.md
index 989120333..e66b0bdd5 100644
--- a/docs/rules/no-invalid-v-pre.md
+++ b/docs/rules/no-invalid-v-pre.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-pre` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-pre` directives if the following cases:
+This rule reports `v-pre` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-pre:aaa></div>`
 - The directive has that modifier. E.g. `<div v-pre.bbb></div>`
diff --git a/docs/rules/no-invalid-v-show.md b/docs/rules/no-invalid-v-show.md
index 1a13ef881..fe0c3fb0b 100644
--- a/docs/rules/no-invalid-v-show.md
+++ b/docs/rules/no-invalid-v-show.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-show` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-show` directives if the following cases:
+This rule reports `v-show` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-show:aaa></div>`
 - The directive has that modifier. E.g. `<div v-show.bbb></div>`
diff --git a/docs/rules/no-invalid-v-text.md b/docs/rules/no-invalid-v-text.md
index 39e966202..2b9513a2b 100644
--- a/docs/rules/no-invalid-v-text.md
+++ b/docs/rules/no-invalid-v-text.md
@@ -4,7 +4,7 @@ This rule checks whether every `v-text` directive is valid.
 
 ## 📖 Rule Details
 
-This rule reports `v-text` directives if the following cases:
+This rule reports `v-text` directives in the following cases:
 
 - The directive has that argument. E.g. `<div v-text:aaa></div>`
 - The directive has that modifier. E.g. `<div v-text.bbb></div>`