Option: treatUndefinedAsUnspecified - allows implicitly returning undefined with a return; statement.

Author: armano2

lib/rules/computed-property-return.js

@@ -7,17 +7,24 @@
 const utils = require('../utils')
 
 function create (context) {
+  const options = context.options[0] || {}
+  const treatUndefinedAsUnspecified = !(options.treatUndefinedAsUnspecified === false)
+
   let funcInfo = {
     funcInfo: null,
     codePath: null,
     hasReturn: false,
+    hasReturnValue: false,
     node: null
   }
   const forbiddenNodes = []
 
   // ----------------------------------------------------------------------
   // Helpers
   // ----------------------------------------------------------------------
+  function isValidReturn () {
+    return (!treatUndefinedAsUnspecified && funcInfo.hasReturn) || (treatUndefinedAsUnspecified && funcInfo.hasReturnValue)
+  }
 
   // ----------------------------------------------------------------------
   // Public
@@ -30,6 +37,7 @@ function create (context) {
           codePath,
           funcInfo: funcInfo,
           hasReturn: false,
+          hasReturnValue: false,
           node
         }
       },
@@ -38,16 +46,10 @@ function create (context) {
       },
       ReturnStatement (node) {
         funcInfo.hasReturn = true
-        if (!node.argument) {
-          forbiddenNodes.push({
-            hasReturn: false,
-            node,
-            type: 'return'
-          })
-        }
+        funcInfo.hasReturnValue = Boolean(node.argument)
       },
       'FunctionExpression:exit' (node) {
-        if (funcInfo.codePath.currentSegments.some((segment) => segment.reachable) && !funcInfo.hasReturn) {
+        if (!isValidReturn() && funcInfo.codePath.currentSegments.some((segment) => segment.reachable)) {
           forbiddenNodes.push({
             hasReturn: funcInfo.hasReturn,
             node: funcInfo.node,
@@ -86,13 +88,21 @@ function create (context) {
 module.exports = {
   meta: {
     docs: {
-      description: 'Enforces that a return statement is present in computed property (computed-property-return)',
-      category: 'Fill me in',
+      description: 'Enforces that a return statement is present in computed property.',
+      category: 'Possible Errors',
       recommended: false
     },
     fixable: null,  // or "code" or "whitespace"
     schema: [
-        // fill in your schema
+      {
+        type: 'object',
+        properties: {
+          treatUndefinedAsUnspecified: {
+            type: 'boolean'
+          }
+        },
+        additionalProperties: false
+      }
     ]
   },
 

tests/lib/rules/computed-property-return.js

@@ -43,6 +43,22 @@ ruleTester.run('computed-property-return', rule, {
         }
       `,
       parserOptions: { ecmaVersion: 8, sourceType: 'module' }
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          computed: {
+            foo: {
+              get () {
+                return
+              }
+            }
+          }
+        }
+      `,
+      parserOptions: { ecmaVersion: 8, sourceType: 'module' },
+      options: [{ treatUndefinedAsUnspecified: false }]
     }
   ],