From d070ab678f89dc9f19b32d83e4e3f7110d2e5291 Mon Sep 17 00:00:00 2001 From: baiwusanyu-c <740132583@qq.com> Date: Fri, 6 Jan 2023 14:06:42 +0800 Subject: [PATCH 1/5] fix(runtime-dom): undefined cssvars should not be bound to the element --- packages/runtime-dom/src/helpers/useCssVars.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/runtime-dom/src/helpers/useCssVars.ts b/packages/runtime-dom/src/helpers/useCssVars.ts index 4bd9838ba75..f8f6422c3b0 100644 --- a/packages/runtime-dom/src/helpers/useCssVars.ts +++ b/packages/runtime-dom/src/helpers/useCssVars.ts @@ -82,8 +82,10 @@ function setVarsOnNode(el: Node, vars: Record) { const style = (el as HTMLElement).style let cssText = '' for (const key in vars) { - style.setProperty(`--${key}`, vars[key]) - cssText += `--${key}: ${vars[key]};` + if(vars[key]){ + style.setProperty(`--${key}`, vars[key]) + cssText += `--${key}: ${vars[key]};` + } } ;(style as any)[CSS_VAR_TEXT] = cssText } From 3bc3412e7791d940496a83a9a88813a5a5880454 Mon Sep 17 00:00:00 2001 From: baiwusanyu <740132583@qq.com> Date: Fri, 6 Jan 2023 23:35:51 +0800 Subject: [PATCH 2/5] fix(runtime-core): update code --- packages/runtime-dom/src/helpers/useCssVars.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/runtime-dom/src/helpers/useCssVars.ts b/packages/runtime-dom/src/helpers/useCssVars.ts index f8f6422c3b0..f3409b28193 100644 --- a/packages/runtime-dom/src/helpers/useCssVars.ts +++ b/packages/runtime-dom/src/helpers/useCssVars.ts @@ -82,7 +82,7 @@ function setVarsOnNode(el: Node, vars: Record) { const style = (el as HTMLElement).style let cssText = '' for (const key in vars) { - if(vars[key]){ + if (vars[key] || vars[key] === '') { style.setProperty(`--${key}`, vars[key]) cssText += `--${key}: ${vars[key]};` } From 91aa700b7228c9a05ed945522fec57b437c09aca Mon Sep 17 00:00:00 2001 From: baiwusanyu <740132583@qq.com> Date: Sun, 8 Jan 2023 22:02:11 +0800 Subject: [PATCH 3/5] fix(runtime-core): update code --- packages/runtime-dom/src/helpers/useCssVars.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/runtime-dom/src/helpers/useCssVars.ts b/packages/runtime-dom/src/helpers/useCssVars.ts index f3409b28193..838c5cded90 100644 --- a/packages/runtime-dom/src/helpers/useCssVars.ts +++ b/packages/runtime-dom/src/helpers/useCssVars.ts @@ -82,7 +82,7 @@ function setVarsOnNode(el: Node, vars: Record) { const style = (el as HTMLElement).style let cssText = '' for (const key in vars) { - if (vars[key] || vars[key] === '') { + if (vars[key] !== undefined && vars[key] !== null) { style.setProperty(`--${key}`, vars[key]) cssText += `--${key}: ${vars[key]};` } From 88f0e09b293885e5dd21b1e10e62d31e8bf944eb Mon Sep 17 00:00:00 2001 From: baiwusanyu <740132583@qq.com> Date: Mon, 9 Jan 2023 22:44:53 +0800 Subject: [PATCH 4/5] fix(runtime-core): update code --- packages/runtime-dom/src/helpers/useCssVars.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/runtime-dom/src/helpers/useCssVars.ts b/packages/runtime-dom/src/helpers/useCssVars.ts index 838c5cded90..8f5519d474a 100644 --- a/packages/runtime-dom/src/helpers/useCssVars.ts +++ b/packages/runtime-dom/src/helpers/useCssVars.ts @@ -82,7 +82,7 @@ function setVarsOnNode(el: Node, vars: Record) { const style = (el as HTMLElement).style let cssText = '' for (const key in vars) { - if (vars[key] !== undefined && vars[key] !== null) { + if (vars[key] != null) { style.setProperty(`--${key}`, vars[key]) cssText += `--${key}: ${vars[key]};` } From 6b36b865ddb134de2a92423c4deb714555f6e770 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Tue, 19 Dec 2023 09:40:30 +0000 Subject: [PATCH 5/5] [autofix.ci] apply automated fixes --- packages/runtime-dom/src/helpers/useCssVars.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/runtime-dom/src/helpers/useCssVars.ts b/packages/runtime-dom/src/helpers/useCssVars.ts index 8f5519d474a..c067f18dce5 100644 --- a/packages/runtime-dom/src/helpers/useCssVars.ts +++ b/packages/runtime-dom/src/helpers/useCssVars.ts @@ -85,7 +85,7 @@ function setVarsOnNode(el: Node, vars: Record) { if (vars[key] != null) { style.setProperty(`--${key}`, vars[key]) cssText += `--${key}: ${vars[key]};` - } + } } ;(style as any)[CSS_VAR_TEXT] = cssText }