fix(runtime-dom): fix the event listeners call in firefox <= 53 #3501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HcySunYang
added
the
❗ p4-important
yyx990803
requested changes
Mar 29, 2021
| @@ -1,4 +1,4 @@ | |||
| import { hyphenate, isArray } from '@vue/shared' | |||
| import { hyphenate, isArray, isFF } from '@vue/shared' | |||
Member
There was a problem hiding this comment.
since isFF isn't actually used anywhere else, and it being very version specific, let's just keep the detection logic here instead of in @vue/shared. Can also directly a variable named bailTimestampCheck.
There was a problem hiding this comment.
@yyx990803 Firefox isn't the only platform that is affected by this. See this 2.6 PR for more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3485
Find relevant information here https://github.com/erdong-fe/vue/commit/d3ce9d31221949cb367c38fa4c09dc3d2f6bef5c
I tested multiple scenarios in FF 52 and it works correctly