Skip to content

Commit 88681b1

Browse files
authored
Merge branch 'vuejs:main' into main
2 parents 6dcbb8b + 423b462 commit 88681b1

37 files changed

+294
-93
lines changed

.github/workflows/size-report.yml

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ permissions:
1313

1414
env:
1515
PUPPETEER_SKIP_DOWNLOAD: 'true'
16+
COMMENT_MARKER: <!-- VUE_CORE_SIZE -->
1617

1718
jobs:
1819
size-report:
@@ -52,20 +53,15 @@ jobs:
5253
path: temp/size-prev
5354
if_no_artifact_found: warn
5455

55-
- name: Compare size
56-
run: pnpm tsx scripts/size-report.ts > size-report.md
57-
58-
- name: Read Size Report
59-
id: size-report
60-
uses: juliangruber/read-file-action@v1
61-
with:
62-
path: ./size-report.md
56+
- name: Prepare report
57+
run: |
58+
pnpm tsx scripts/size-report.ts > size-report.md
59+
echo '${{ env.COMMENT_MARKER }}' >> size-report.md
6360
6461
- name: Create Comment
65-
uses: actions-cool/maintain-one-comment@v3
62+
uses: thollander/actions-[email protected]
6663
with:
67-
token: ${{ secrets.GITHUB_TOKEN }}
68-
body: |
69-
${{ steps.size-report.outputs.content }}
70-
<!-- VUE_CORE_SIZE -->
71-
body-include: '<!-- VUE_CORE_SIZE -->'
64+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
65+
filePath: size-report.md
66+
comment_tag: ${{ env.COMMENT_MARKER }}
67+
pr_number: ${{ github.event.workflow_run.pull_requests[0].number }}

CHANGELOG.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,24 @@
1+
## [3.4.30](https://github.com/vuejs/core/compare/v3.4.29...v3.4.30) (2024-06-22)
2+
3+
4+
### Bug Fixes
5+
6+
* **compiler-core:** should not remove slot node with `v-else` ([#11150](https://github.com/vuejs/core/issues/11150)) ([e102670](https://github.com/vuejs/core/commit/e102670bde00417c3a5b0262c855b297c0e4169e))
7+
* **hydration:** fix css vars hydration mismatch false positive on attr-fallthrough ([#11190](https://github.com/vuejs/core/issues/11190)) ([7ad67ce](https://github.com/vuejs/core/commit/7ad67ced26e5f53a47cb42f4834496e4958cb53b)), closes [#11188](https://github.com/vuejs/core/issues/11188)
8+
* **hydration:** skip prop mismatch check for directives that mutate DOM in created ([3169c91](https://github.com/vuejs/core/commit/3169c914939d02a013b2938aff30dac8525923f8)), closes [#11189](https://github.com/vuejs/core/issues/11189)
9+
* **reactivity:** fix side effect computed dirty level ([#11183](https://github.com/vuejs/core/issues/11183)) ([3bd79e3](https://github.com/vuejs/core/commit/3bd79e3e5ed960fc42cbf77bc61a97d2c03557c0)), closes [#11181](https://github.com/vuejs/core/issues/11181) [#11169](https://github.com/vuejs/core/issues/11169)
10+
* **runtime-core:** ensure unmount dynamic components in optimized mode ([#11171](https://github.com/vuejs/core/issues/11171)) ([220fe24](https://github.com/vuejs/core/commit/220fe247484209e62c7f4991902c5335e29c5007)), closes [#11168](https://github.com/vuejs/core/issues/11168)
11+
* **runtime-core:** update devtool __vnode on patch, avoid memory leak during dev ([a959781](https://github.com/vuejs/core/commit/a959781dd6f609dcb6f16dd7fa47d3b16895e5ca)), closes [#11192](https://github.com/vuejs/core/issues/11192)
12+
* **runtime-dom:** ensure only symbols are explicitly stringified during attribute patching ([#11182](https://github.com/vuejs/core/issues/11182)) ([a2e35d6](https://github.com/vuejs/core/commit/a2e35d682db15a592f4270bb0cde70a0e7bdc4a6)), closes [#11177](https://github.com/vuejs/core/issues/11177)
13+
* **runtime-dom:** prevent setting state as attribute for custom elements ([#11165](https://github.com/vuejs/core/issues/11165)) ([8ae4c29](https://github.com/vuejs/core/commit/8ae4c293adcec28f18114cb6016230a86787e6a9)), closes [#11163](https://github.com/vuejs/core/issues/11163)
14+
15+
16+
### Performance Improvements
17+
18+
* **reactivity:** cache tracking value ([#11145](https://github.com/vuejs/core/issues/11145)) ([7936dae](https://github.com/vuejs/core/commit/7936daebceab2ae9461c3b8f256e51020fb7d3ed))
19+
20+
21+
122
## [3.4.29](https://github.com/vuejs/core/compare/v3.4.28...v3.4.29) (2024-06-14)
223

324

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"private": true,
3-
"version": "3.4.29",
3+
"version": "3.4.30",
44
"packageManager": "[email protected]",
55
"type": "module",
66
"scripts": {

packages/compiler-core/__tests__/transforms/vSlot.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -696,6 +696,7 @@ describe('compiler: transform component slots', () => {
696696
expect((root as any).children[0].codegenNode.patchFlag).toMatch(
697697
PatchFlags.DYNAMIC_SLOTS + '',
698698
)
699+
expect((root as any).children[0].children.length).toBe(3)
699700
expect(generate(root).code).toMatchSnapshot()
700701
})
701702

packages/compiler-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@vue/compiler-core",
3-
"version": "3.4.29",
3+
"version": "3.4.30",
44
"description": "@vue/compiler-core",
55
"main": "index.js",
66
"module": "dist/compiler-core.esm-bundler.js",

packages/compiler-core/src/compat/transformFilter.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ export const transformFilter: NodeTransform = (node, context) => {
2525
// filter rewrite is applied before expression transform so only
2626
// simple expressions are possible at this stage
2727
rewriteFilter(node.content, context)
28-
}
29-
30-
if (node.type === NodeTypes.ELEMENT) {
28+
} else if (node.type === NodeTypes.ELEMENT) {
3129
node.props.forEach((prop: AttributeNode | DirectiveNode) => {
3230
if (
3331
prop.type === NodeTypes.DIRECTIVE &&

packages/compiler-core/src/transforms/vSlot.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,7 @@ export function buildSlots(
226226
break
227227
}
228228
}
229-
if (prev && isTemplateNode(prev) && findDir(prev, 'if')) {
230-
// remove node
231-
children.splice(i, 1)
232-
i--
229+
if (prev && isTemplateNode(prev) && findDir(prev, /^(else-)?if$/)) {
233230
__TEST__ && assert(dynamicSlots.length > 0)
234231
// attach this slot to previous conditional
235232
let conditional = dynamicSlots[

packages/compiler-dom/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@vue/compiler-dom",
3-
"version": "3.4.29",
3+
"version": "3.4.30",
44
"description": "@vue/compiler-dom",
55
"main": "index.js",
66
"module": "dist/compiler-dom.esm-bundler.js",

packages/compiler-sfc/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@vue/compiler-sfc",
3-
"version": "3.4.29",
3+
"version": "3.4.30",
44
"description": "@vue/compiler-sfc",
55
"main": "dist/compiler-sfc.cjs.js",
66
"module": "dist/compiler-sfc.esm-browser.js",

packages/compiler-ssr/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@vue/compiler-ssr",
3-
"version": "3.4.29",
3+
"version": "3.4.30",
44
"description": "@vue/compiler-ssr",
55
"main": "dist/compiler-ssr.cjs.js",
66
"types": "dist/compiler-ssr.d.ts",

0 commit comments

Comments
 (0)