refactor(types): bundle client types (#9966)

Author: sapphi-red

.eslintignore

@@ -1,4 +1,4 @@
 dist
 playground-temp
 temp
-
+packages/vite/client/types.d.ts

.eslintrc.cjs

@@ -131,7 +131,7 @@ module.exports = defineConfig({
       }
     },
     {
-      files: ['packages/vite/types/**', '*.spec.ts'],
+      files: ['packages/vite/src/dep-types/**', '*.spec.ts'],
       rules: {
         'node/no-extraneous-import': 'off'
       }

.gitignore

@@ -5,6 +5,7 @@
 *.local
 *.log
 /.vscode/
+/packages/vite/client/types.d.ts
 /packages/vite/LICENSE
 dist
 dist-ssr

.prettierignore

@@ -9,3 +9,4 @@ playground/tsconfig-json-load-error/has-error/tsconfig.json
 playground/html/invalid.html
 playground/html/valid.html
 playground/worker/classic-worker.js
+packages/vite/client/types.d.ts

CONTRIBUTING.md

@@ -218,7 +218,7 @@ Avoid deps with large transitive dependencies that result in bloated size compar
 
 Vite aims to be fully usable as a dependency in a TypeScript project (e.g. it should provide proper typings for VitePress), and also in `vite.config.ts`. This means technically a dependency whose types are exposed needs to be part of `dependencies` instead of `devDependencies`. However, this also means we won't be able to bundle it.
 
-To get around this, we inline some of these dependencies' types in `packages/vite/types`. This way, we can still expose the typing but bundle the dependency's source code.
+To get around this, we inline some of these dependencies' types in `packages/vite/src/dep-types`. This way, we can still expose the typing but bundle the dependency's source code.
 
 Use `pnpm run check-dist-types` to check that the bundled types do not rely on types in `devDependencies`. If you are adding `dependencies`, make sure to configure `tsconfig.check.json`.
 

docs/guide/api-plugin.md

@@ -595,12 +595,21 @@ It is possible to type custom events by extending the `CustomEventMap` interface
 
 ```ts
 // events.d.ts
-import 'vite/types/customEvent'
+import 'vite'
+import 'vite/client/types'
 
-declare module 'vite/types/customEvent' {
-  interface CustomEventMap {
-    'custom:foo': { msg: string }
-    // 'event-key': payload
-  }
+interface MyCustomEventMap {
+  'custom:foo': { msg: string }
+  // 'event-key': payload
+}
+
+// extend interface for server-side
+declare module 'vite' {
+  interface CustomEventMap extends MyCustomEventMap {}
+}
+
+// extend interface for client-side
+declare module 'vite/client/types' {
+  interface CustomEventMap extends MyCustomEventMap {}
 }
 ```

packages/plugin-legacy/tsconfig.json

@@ -12,7 +12,6 @@
     "noUnusedLocals": true,
     "esModuleInterop": true,
     "paths": {
-      "types/*": ["../vite/types/*"],
       "vite": ["../vite/src/node/index.js"]
     }
   }

packages/plugin-react/tsconfig.json

@@ -12,7 +12,6 @@
     "noUnusedLocals": true,
     "esModuleInterop": true,
     "paths": {
-      "types/*": ["../vite/types/*"],
       "vite": ["../vite/src/node/index.js"]
     }
   }

packages/plugin-vue-jsx/tsconfig.json

@@ -12,7 +12,6 @@
     "noUnusedLocals": true,
     "esModuleInterop": true,
     "paths": {
-      "types/*": ["../vite/types/*"],
       "vite": ["../vite/src/node/index.js"]
     }
   }

packages/plugin-vue/tsconfig.json

@@ -14,7 +14,6 @@
     "esModuleInterop": true,
     "baseUrl": ".",
     "paths": {
-      "types/*": ["../vite/types/*"],
       "vite": ["../vite/src/node/index.js"]
     }
   }