Skip to content

Commit ce6f2fd

Browse files
[dev-overlay] Polish mobile view (#78863)
Just making the mobile experience a bit better by removing notch design to make better use of constrained space. ![image](https://github.com/user-attachments/assets/40339401-7b2b-41c5-9a72-7cf3ce3746d7)
1 parent a64130e commit ce6f2fd

File tree

2 files changed

+37
-10
lines changed

2 files changed

+37
-10
lines changed

packages/next/src/client/components/react-dev-overlay/ui/components/dialog/styles.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ const styles = `
7171
transition: opacity var(--transition-duration) var(--timing-overlay);
7272
}
7373
74+
[data-nextjs-dialog-overlay] {
75+
margin: 8px;
76+
}
77+
7478
[data-nextjs-dialog-overlay][data-rendered='true']
7579
[data-nextjs-dialog-backdrop] {
7680
opacity: 1;

packages/next/src/client/components/react-dev-overlay/ui/components/errors/error-overlay-nav/error-overlay-nav.tsx

Lines changed: 33 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ export function ErrorOverlayNav({
4747

4848
export const styles = `
4949
[data-nextjs-error-overlay-nav] {
50+
--stroke-color: var(--color-gray-400);
51+
--background-color: var(--color-background-100);
5052
display: flex;
5153
justify-content: space-between;
5254
align-items: center;
@@ -56,25 +58,22 @@ export const styles = `
5658
position: relative;
5759
z-index: 2;
5860
outline: none;
59-
translate: 1px 1px;
61+
translate: var(--next-dialog-border-width) var(--next-dialog-border-width);
6062
max-width: var(--next-dialog-max-width);
6163
6264
.error-overlay-notch {
63-
--stroke-color: var(--color-gray-400);
64-
--background-color: var(--color-background-100);
65-
66-
translate: -1px 0;
65+
translate: calc(var(--next-dialog-border-width) * -1);
6766
width: auto;
6867
height: var(--next-dialog-notch-height);
6968
padding: 12px;
7069
background: var(--background-color);
71-
border: 1px solid var(--stroke-color);
70+
border: var(--next-dialog-border-width) solid var(--stroke-color);
7271
border-bottom: none;
7372
position: relative;
7473
7574
&[data-side='left'] {
7675
padding-right: 0;
77-
border-radius: var(--rounded-xl) 0 0 0;
76+
border-radius: var(--next-dialog-radius) 0 0 0;
7877
7978
.error-overlay-notch-tail {
8079
right: -54px;
@@ -87,7 +86,7 @@ export const styles = `
8786
8887
&[data-side='right'] {
8988
padding-left: 0;
90-
border-radius: 0 var(--rounded-xl) 0 0;
89+
border-radius: 0 var(--next-dialog-radius) 0 0;
9190
9291
.error-overlay-notch-tail {
9392
left: -54px;
@@ -101,10 +100,34 @@ export const styles = `
101100
102101
.error-overlay-notch-tail {
103102
position: absolute;
104-
top: -1px;
103+
top: calc(var(--next-dialog-border-width) * -1);
105104
pointer-events: none;
106105
z-index: -1;
107-
height: calc(100% + 1px);
106+
height: calc(100% + var(--next-dialog-border-width));
107+
}
108+
}
109+
}
110+
111+
@media (max-width: 600px) {
112+
[data-nextjs-error-overlay-nav] {
113+
background: var(--background-color);
114+
border-radius: var(--next-dialog-radius) var(--next-dialog-radius) 0 0;
115+
border: var(--next-dialog-border-width) solid var(--stroke-color);
116+
border-bottom: none;
117+
overflow: hidden;
118+
translate: 0 var(--next-dialog-border-width);
119+
120+
.error-overlay-notch {
121+
border-radius: 0;
122+
border: 0;
123+
124+
&[data-side="left"], &[data-side="right"] {
125+
border-radius: 0;
126+
}
127+
128+
.error-overlay-notch-tail {
129+
display: none;
130+
}
108131
}
109132
}
110133
}

0 commit comments

Comments
 (0)