Skip to content

Commit 8eb781d

Browse files
committed
Merge remote-tracking branch 'upstream/canary' into required-server-files
# Conflicts: # packages/next/next-server/server/next-server.ts
2 parents 467e951 + 9bdb793 commit 8eb781d

File tree

42 files changed

+322
-46
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+322
-46
lines changed

.github/workflows/cancel.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Cancel
2+
on:
3+
pull_request_target:
4+
types:
5+
- edited
6+
- synchronize
7+
8+
jobs:
9+
cancel:
10+
name: 'Cancel Previous Runs'
11+
runs-on: ubuntu-latest
12+
timeout-minutes: 2
13+
steps:
14+
- uses: styfle/[email protected]
15+
with:
16+
workflow_id: 444921, 444987
17+
access_token: ${{ github.token }}

errors/next-export-no-build-id.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Could not find a production build
2+
3+
#### Why This Error Occurred
4+
5+
When running `next export` a production build is needed.
6+
7+
#### Possible Ways to Fix It
8+
9+
- Run `next build` to create a production build before running `next export`.
10+
- If your intention was to run the development server run `next dev` instead.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Could not find a production build
2+
3+
#### Why This Error Occurred
4+
5+
When running `next start` or a custom server in production mode a production build is needed.
6+
7+
#### Possible Ways to Fix It
8+
9+
- Run `next build` to create a production build before booting up the production server.
10+
- If your intention was to run the development server run `next dev` instead.

examples/with-apollo/pages/client-only.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const ClientOnlyPage = (props) => (
88
<App>
99
<Header />
1010
<InfoBox>
11-
ℹ️ This page shows how use Apollo only in the client. If you{' '}
11+
ℹ️ This page shows how to use Apollo only in the client. If you{' '}
1212
<a href="/client-only">reload</a> this page, you will see a loader since
1313
Apollo didn't fetch any data on the server. This is useful when the page
1414
doesn't have SEO requirements or blocking data fetching requirements.

examples/with-docker/Dockerfile.multistage

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ RUN yarn install --production --frozen-lockfile
1414

1515

1616
# Stage 2: And then copy over node_modules, etc from that stage to the smaller base image
17-
FROM mhart/alpine-node:base as production
17+
FROM mhart/alpine-node:slim as production
1818

1919
WORKDIR /app
2020

examples/with-electron/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Electron application example
22

3-
This example show how you can use Next.js inside an Electron application to avoid a lot of configuration, use Next.js router as view and use server-render to speed up the initial render of the application.
3+
This example shows how you can use Next.js inside an Electron application to avoid a lot of configuration. It uses the Next.js router as view and server-render to speed up the initial render of the application.
44

5-
For development it's going to run a HTTP server and let Next.js handle routing. In production it use `next export` to pre-generate HTML static files and use them in your app instead of running an HTTP server.
5+
For development it's going to run an HTTP server and let Next.js handle routing. In production it uses `next export` to pre-generate HTML static files and uses them in your app instead of running an HTTP server.
66

77
**You can find a detailed documentation about how to build Electron apps with Next.js [here](https://leo.im/2017/electron-next)!**
88

examples/with-facebook-pixel/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Example app using Facebook Pixel
22

3-
This example shows how to use Next.js along with Facebook Pixel. A [custom `App`](https://nextjs.org/docs/advanced-features/custom-app) is used to track route changes and send page views to Facebook Pixel. This example uses [react-facebook-pixel](https://www.npmjs.com/package/react-facebook-pixel).
3+
This example shows how to use Next.js along with Facebook Pixel. A custom [\_document](https://nextjs.org/docs/advanced-features/custom-document) is used to inject [base code](https://developers.facebook.com/docs/facebook-pixel/implementation/?locale=en_US). A [\_app](https://nextjs.org/docs/advanced-features/custom-app) is used to track route changes and send page views to Facebook Pixel.
44

55
## Deploy your own
66

@@ -24,6 +24,6 @@ Next, copy the `.env.local.example` file in this directory to `.env.local` (whic
2424
cp .env.local.example .env.local
2525
```
2626

27-
Set the `NEXT_PUBLIC_FACEBOOK_PIXEL_ID` variable in `.env.local` to match your facebook app's pixel ID. If not specified, tracking will be disabled.
27+
Set the `NEXT_PUBLIC_FACEBOOK_PIXEL_ID` variable in `.env.local` to match your facebook app's pixel ID.
2828

2929
Deploy it to the cloud with [Vercel](https://vercel.com/import?filter=next.js&utm_source=github&utm_medium=readme&utm_campaign=next-example) ([Documentation](https://nextjs.org/docs/deployment)).

examples/with-facebook-pixel/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
"dependencies": {
1010
"next": "latest",
1111
"react": "^16.13.1",
12-
"react-dom": "^16.13.1",
13-
"react-facebook-pixel": "^1.0.3"
12+
"react-dom": "^16.13.1"
1413
},
1514
"license": "MIT"
1615
}

lerna.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@
1717
"registry": "https://registry.npmjs.org/"
1818
}
1919
},
20-
"version": "10.0.4-canary.2"
20+
"version": "10.0.4-canary.3"
2121
}

packages/create-next-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "create-next-app",
3-
"version": "10.0.4-canary.2",
3+
"version": "10.0.4-canary.3",
44
"keywords": [
55
"react",
66
"next",

0 commit comments

Comments
 (0)