Skip to content

Commit 13dc49e

Browse files
authored
Disable React 18 tests on PRs (#70541)
New CI budget is not approved yet and the hydration tests are flaky. There's no active work on Pages router so this is safe-ish to ignore to unblock work on App router which doesn't run on the installed React anyway.
1 parent e6b1232 commit 13dc49e

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

.github/workflows/build_and_test.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,9 @@ jobs:
202202
strategy:
203203
fail-fast: false
204204
matrix:
205+
exclude:
206+
# Excluding React 18 tests unless on `canary` branch until budget is approved.
207+
- react: ${{ github.event_name == 'pull_request' && '18.3.1' }}
205208
group: [1/5, 2/5, 3/5, 4/5, 5/5]
206209
# Empty value uses default
207210
react: ['', '18.3.1']
@@ -219,6 +222,9 @@ jobs:
219222
strategy:
220223
fail-fast: false
221224
matrix:
225+
exclude:
226+
# Excluding React 18 tests unless on `canary` branch until budget is approved.
227+
- react: ${{ github.event_name == 'pull_request' && '18.3.1' }}
222228
group: [1/5, 2/5, 3/5, 4/5, 5/5]
223229
# Empty value uses default
224230
react: ['']
@@ -237,6 +243,9 @@ jobs:
237243
strategy:
238244
fail-fast: false
239245
matrix:
246+
exclude:
247+
# Excluding React 18 tests unless on `canary` branch until budget is approved.
248+
- react: ${{ github.event_name == 'pull_request' && '18.3.1' }}
240249
group: [1/5, 2/5, 3/5, 4/5, 5/5]
241250
# Empty value uses default
242251
# TODO: Run with React 18.
@@ -372,6 +381,9 @@ jobs:
372381
strategy:
373382
fail-fast: false
374383
matrix:
384+
exclude:
385+
# Excluding React 18 tests unless on `canary` branch until budget is approved.
386+
- react: ${{ github.event_name == 'pull_request' && '18.3.1' }}
375387
group: [1/4, 2/4, 3/4, 4/4]
376388
# Empty value uses default
377389
react: ['', '18.3.1']
@@ -389,6 +401,9 @@ jobs:
389401
strategy:
390402
fail-fast: false
391403
matrix:
404+
exclude:
405+
# Excluding React 18 tests unless on `canary` branch until budget is approved.
406+
- react: ${{ github.event_name == 'pull_request' && '18.3.1' }}
392407
group: [1/5, 2/5, 3/5, 4/5, 5/5]
393408
# Empty value uses default
394409
react: ['', '18.3.1']

0 commit comments

Comments
 (0)