fix: Address Lint configuration errors

- Populate all PushKind enum values in IsMessageNotification switch
- Remove unnecessary using directives (System, System.Collections.Generic)
- Remove unused private fields (_callbackExceptions, _receivedMessages)
- Fix xUnit2022: Use Assert.False instead of Assert.True with negation
- Keep System.Diagnostics using for Stopwatch (not in implicit usings for Lint config)

All lint errors resolved. Build passes with --configuration Lint.

Signed-off-by: Joe Brinkman <[email protected]>

Author: jbrinkman

sources/Valkey.Glide/BaseClient.cs

@@ -228,10 +228,19 @@ private void PubSubCallback(
     private static bool IsMessageNotification(PushKind pushKind) =>
         pushKind switch
         {
-            PushKind.PushMessage => true,      // Regular channel message
-            PushKind.PushPMessage => true,     // Pattern-based message
-            PushKind.PushSMessage => true,     // Sharded channel message
-            _ => false                         // All other types are confirmations/notifications
+            PushKind.PushMessage => true,       // Regular channel message
+            PushKind.PushPMessage => true,      // Pattern-based message
+            PushKind.PushSMessage => true,      // Sharded channel message
+            PushKind.PushDisconnection => false,
+            PushKind.PushOther => false,
+            PushKind.PushInvalidate => false,
+            PushKind.PushUnsubscribe => false,
+            PushKind.PushPUnsubscribe => false,
+            PushKind.PushSUnsubscribe => false,
+            PushKind.PushSubscribe => false,
+            PushKind.PushPSubscribe => false,
+            PushKind.PushSSubscribe => false,
+            _ => false
         };
 
     private static PubSubMessage MarshalPubSubMessage(

sources/Valkey.Glide/PubSubPerformanceConfig.cs

@@ -1,6 +1,5 @@
 // Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
 
-using System;
 using System.Threading.Channels;
 
 namespace Valkey.Glide;

sources/Valkey.Glide/PubSubSubscriptionConfig.cs

@@ -1,8 +1,5 @@
 // Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
 
-using System;
-using System.Collections.Generic;
-
 namespace Valkey.Glide;
 
 /// <summary>

tests/Valkey.Glide.IntegrationTests/PubSubCallbackIntegrationTests.cs

@@ -1,10 +1,7 @@
 // Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
 
-using System.Collections.Concurrent;
 using System.Diagnostics;
 
-using Valkey.Glide;
-
 namespace Valkey.Glide.IntegrationTests;
 
 /// <summary>
@@ -16,8 +13,6 @@ namespace Valkey.Glide.IntegrationTests;
 public class PubSubCallbackIntegrationTests : IDisposable
 {
     private readonly List<BaseClient> _testClients = [];
-    private readonly ConcurrentBag<Exception> _callbackExceptions = [];
-    private readonly ConcurrentBag<PubSubMessage> _receivedMessages = [];
     private readonly ManualResetEventSlim _messageReceivedEvent = new(false);
     private readonly object _lockObject = new();
 
@@ -478,7 +473,7 @@ public async Task ErrorIsolation_WithMessageHandlerExceptions_DoesNotCrashProces
         Assert.True(callbackCount >= 3, "All callbacks should have been invoked despite exceptions");
 
         // Process should still be running (not crashed)
-        Assert.True(!Environment.HasShutdownStarted, "Process should not have initiated shutdown");
+        Assert.False(Environment.HasShutdownStarted, "Process should not have initiated shutdown");
     }
 
     [Fact]