Skip to content

Commit 4dd2f0c

Browse files
committed
Merge tests to one
1 parent 1d7fffc commit 4dd2f0c

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

tests/sqlparser_snowflake.rs

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4615,8 +4615,8 @@ fn test_drop_constraints() {
46154615
}
46164616

46174617
#[test]
4618-
fn test_semantic_view_all_variants_should_pass() {
4619-
let test_cases = [
4618+
fn test_semantic_view() {
4619+
let valid_sqls = [
46204620
("SELECT * FROM SEMANTIC_VIEW(model)", None),
46214621
(
46224622
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1, dim2)",
@@ -4666,7 +4666,7 @@ fn test_semantic_view_all_variants_should_pass() {
46664666
),
46674667
];
46684668

4669-
for (input_sql, expected_sql) in test_cases {
4669+
for (input_sql, expected_sql) in valid_sqls {
46704670
if let Some(expected) = expected_sql {
46714671
// Test that non-canonical order gets normalized
46724672
let parsed = snowflake().parse_sql_statements(input_sql).unwrap();
@@ -4676,10 +4676,7 @@ fn test_semantic_view_all_variants_should_pass() {
46764676
snowflake().verified_stmt(input_sql);
46774677
}
46784678
}
4679-
}
46804679

4681-
#[test]
4682-
fn test_semantic_view_invalid_queries_should_fail() {
46834680
let invalid_sqls = [
46844681
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 INVALID inv1)",
46854682
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 DIMENSIONS dim2)",
@@ -4690,18 +4687,15 @@ fn test_semantic_view_invalid_queries_should_fail() {
46904687
let result = snowflake().parse_sql_statements(sql);
46914688
assert!(result.is_err(), "Expected error for invalid SQL: {}", sql);
46924689
}
4693-
}
46944690

4695-
#[test]
4696-
fn test_semantic_view_ast_structure() {
4697-
let sql = r#"SELECT * FROM SEMANTIC_VIEW(
4691+
let ast_sql = r#"SELECT * FROM SEMANTIC_VIEW(
46984692
my_model
46994693
DIMENSIONS DATE_PART('year', date_col), region_name
47004694
METRICS orders.revenue, orders.count
47014695
WHERE active = true
47024696
) AS model_alias"#;
47034697

4704-
let stmt = snowflake().parse_sql_statements(sql).unwrap();
4698+
let stmt = snowflake().parse_sql_statements(ast_sql).unwrap();
47054699
match &stmt[0] {
47064700
Statement::Query(q) => {
47074701
if let SetExpr::Select(select) = q.body.as_ref() {

0 commit comments

Comments
 (0)