Add support for SEMANTIC_VIEW table factor

bombsimon · bombsimon · commit 2ca88f9cae50 · 2025-08-20T18:24:02.000+02:00
diff --git a/src/ast/query.rs b/src/ast/query.rs
@@ -1410,6 +1410,31 @@ pub enum TableFactor {
         /// The alias for the table.
         alias: Option<TableAlias>,
     },
+    /// Snowflake's SEMANTIC_VIEW function for semantic models.
+    ///
+    /// <https://docs.snowflake.com/en/user-guide/views-semantic/querying>
+    ///
+    /// ```sql
+    /// SELECT * FROM SEMANTIC_VIEW(
+    ///     tpch_analysis
+    ///     DIMENSIONS customer.customer_market_segment
+    ///     METRICS orders.order_average_value
+    /// );
+    /// ```
+    SemanticView {
+        /// The name of the semantic model
+        name: ObjectName,
+        /// List of dimensions (can be expressions like DATE_PART('year', col))
+        dimensions: Vec<Expr>,
+        /// List of metrics (can be expressions or simple names)
+        metrics: Vec<Expr>,
+        /// List of facts
+        facts: Vec<Expr>,
+        /// WHERE clause for filtering
+        where_clause: Option<Expr>,
+        /// The alias for the table
+        alias: Option<TableAlias>,
+    },
 }
 
 /// The table sample modifier options
@@ -2107,6 +2132,40 @@ impl fmt::Display for TableFactor {
                 }
                 Ok(())
             }
+            TableFactor::SemanticView {
+                name,
+                dimensions,
+                metrics,
+                facts,
+                where_clause,
+                alias,
+            } => {
+                write!(f, "SEMANTIC_VIEW({name}")?;
+
+                if !dimensions.is_empty() {
+                    write!(f, " DIMENSIONS {}", display_comma_separated(dimensions))?;
+                }
+
+                if !metrics.is_empty() {
+                    write!(f, " METRICS {}", display_comma_separated(metrics))?;
+                }
+
+                if !facts.is_empty() {
+                    write!(f, " FACTS {}", display_comma_separated(facts))?;
+                }
+
+                if let Some(where_clause) = where_clause {
+                    write!(f, " WHERE {where_clause}")?;
+                }
+
+                write!(f, ")")?;
+
+                if let Some(alias) = alias {
+                    write!(f, " AS {alias}")?;
+                }
+
+                Ok(())
+            }
         }
     }
 }
diff --git a/src/ast/spans.rs b/src/ast/spans.rs
@@ -2032,6 +2032,23 @@ impl Spanned for TableFactor {
                     .chain(symbols.iter().map(|i| i.span()))
                     .chain(alias.as_ref().map(|i| i.span())),
             ),
+            TableFactor::SemanticView {
+                name,
+                dimensions,
+                metrics,
+                facts,
+                where_clause,
+                alias,
+            } => union_spans(
+                name.0
+                    .iter()
+                    .map(|i| i.span())
+                    .chain(dimensions.iter().map(|d| d.span()))
+                    .chain(metrics.iter().map(|m| m.span()))
+                    .chain(facts.iter().map(|f| f.span()))
+                    .chain(where_clause.as_ref().map(|e| e.span()))
+                    .chain(alias.as_ref().map(|a| a.span())),
+            ),
             TableFactor::OpenJsonTable { .. } => Span::empty(),
         }
     }
diff --git a/src/dialect/mod.rs b/src/dialect/mod.rs
@@ -1182,6 +1182,20 @@ pub trait Dialect: Debug + Any {
     fn supports_create_table_like_parenthesized(&self) -> bool {
         false
     }
+
+    /// Returns true if the dialect supports `SEMANTIC_VIEW()` table functions.
+    ///
+    /// ```sql
+    /// SELECT * FROM SEMANTIC_VIEW(
+    ///     model_name
+    ///     DIMENSIONS customer.name, customer.region
+    ///     METRICS orders.revenue, orders.count
+    ///     WHERE customer.active = true
+    /// )
+    /// ```
+    fn supports_semantic_view(&self) -> bool {
+        false
+    }
 }
 
 /// This represents the operators for which precedence must be defined
diff --git a/src/dialect/snowflake.rs b/src/dialect/snowflake.rs
@@ -564,6 +564,10 @@ impl Dialect for SnowflakeDialect {
     fn supports_select_wildcard_exclude(&self) -> bool {
         true
     }
+
+    fn supports_semantic_view(&self) -> bool {
+        true
+    }
 }
 
 // Peeks ahead to identify tokens that are expected after
diff --git a/src/keywords.rs b/src/keywords.rs
@@ -289,6 +289,7 @@ define_keywords!(
     DETACH,
     DETAIL,
     DETERMINISTIC,
+    DIMENSIONS,
     DIRECTORY,
     DISABLE,
     DISCARD,
@@ -357,6 +358,7 @@ define_keywords!(
     EXTERNAL,
     EXTERNAL_VOLUME,
     EXTRACT,
+    FACTS,
     FAIL,
     FAILOVER,
     FALSE,
@@ -560,6 +562,7 @@ define_keywords!(
     METADATA,
     METHOD,
     METRIC,
+    METRICS,
     MICROSECOND,
     MICROSECONDS,
     MILLENIUM,
@@ -817,6 +820,7 @@ define_keywords!(
     SECURITY,
     SEED,
     SELECT,
+    SEMANTIC_VIEW,
     SEMI,
     SENSITIVE,
     SEPARATOR,
diff --git a/src/parser/mod.rs b/src/parser/mod.rs
@@ -13324,6 +13324,7 @@ impl<'a> Parser<'a> {
                         | TableFactor::Pivot { alias, .. }
                         | TableFactor::Unpivot { alias, .. }
                         | TableFactor::MatchRecognize { alias, .. }
+                        | TableFactor::SemanticView { alias, .. }
                         | TableFactor::NestedJoin { alias, .. } => {
                             // but not `FROM (mytable AS alias1) AS alias2`.
                             if let Some(inner_alias) = alias {
@@ -13438,6 +13439,10 @@ impl<'a> Parser<'a> {
         } else if self.parse_keyword_with_tokens(Keyword::XMLTABLE, &[Token::LParen]) {
             self.prev_token();
             self.parse_xml_table_factor()
+        } else if self.dialect.supports_semantic_view()
+            && self.parse_keyword_with_tokens(Keyword::SEMANTIC_VIEW, &[Token::LParen])
+        {
+            self.parse_semantic_view_table_factor()
         } else {
             let name = self.parse_object_name(true)?;
 
@@ -13769,6 +13774,63 @@ impl<'a> Parser<'a> {
         Ok(XmlPassingClause { arguments })
     }
 
+    fn parse_semantic_view_table_factor(&mut self) -> Result<TableFactor, ParserError> {
+        let name = self.parse_object_name(true)?;
+
+        // Parse DIMENSIONS, METRICS, and FACTS clauses in flexible order
+        let mut dimensions = Vec::new();
+        let mut metrics = Vec::new();
+        let mut facts = Vec::new();
+
+        // Keep parsing DIMENSIONS, METRICS, and FACTS clauses until we hit WHERE or closing parenthesis
+        while self.peek_token().token != Token::RParen {
+            if self.parse_keyword(Keyword::DIMENSIONS) {
+                if !dimensions.is_empty() {
+                    return Err(ParserError::ParserError(
+                        "DIMENSIONS clause can only be specified once".to_string(),
+                    ));
+                }
+                dimensions = self.parse_comma_separated(Parser::parse_expr)?;
+            } else if self.parse_keyword(Keyword::METRICS) {
+                if !metrics.is_empty() {
+                    return Err(ParserError::ParserError(
+                        "METRICS clause can only be specified once".to_string(),
+                    ));
+                }
+                metrics = self.parse_comma_separated(Parser::parse_expr)?;
+            } else if self.parse_keyword(Keyword::FACTS) {
+                if !facts.is_empty() {
+                    return Err(ParserError::ParserError(
+                        "FACTS clause can only be specified once".to_string(),
+                    ));
+                }
+                facts = self.parse_comma_separated(Parser::parse_expr)?;
+            } else {
+                // If we hit WHERE or anything else, stop parsing these clauses
+                break;
+            }
+        }
+
+        let where_clause = if self.parse_keyword(Keyword::WHERE) {
+            Some(self.parse_expr()?)
+        } else {
+            None
+        };
+
+        self.expect_token(&Token::RParen)?;
+
+        let alias = self.maybe_parse_table_alias()?;
+
+        Ok(TableFactor::SemanticView {
+            name,
+            dimensions,
+            metrics,
+            facts,
+            where_clause,
+            alias,
+        })
+    }
+
     fn parse_match_recognize(&mut self, table: TableFactor) -> Result<TableFactor, ParserError> {
         self.expect_token(&Token::LParen)?;
 
diff --git a/tests/sqlparser_snowflake.rs b/tests/sqlparser_snowflake.rs
@@ -4581,3 +4581,128 @@ fn test_drop_constraints() {
     snowflake().verified_stmt("ALTER TABLE tbl DROP FOREIGN KEY k1 RESTRICT");
     snowflake().verified_stmt("ALTER TABLE tbl DROP CONSTRAINT c1 CASCADE");
 }
+
+#[test]
+fn test_semantic_view_all_variants() {
+    let test_cases = [
+        ("SELECT * FROM SEMANTIC_VIEW(model)", None),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1, dim2)",
+            None,
+        ),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model METRICS met1, met2)",
+            None,
+        ),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model FACTS fact1, fact2)",
+            None,
+        ),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 METRICS met1)",
+            None,
+        ),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 WHERE x > 0)",
+            None,
+        ),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1) AS sv",
+            None,
+        ),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS DATE_PART('year', col))",
+            None,
+        ),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model METRICS SUM(col), AVG(col2))",
+            None,
+        ),
+        // We can parse in any order bu will always produce a result in a fixed order.
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model METRICS met1 DIMENSIONS dim1)",
+            Some("SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 METRICS met1)"),
+        ),
+        (
+            "SELECT * FROM SEMANTIC_VIEW(model FACTS fact1 DIMENSIONS dim1)",
+            Some("SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 FACTS fact1)"),
+        ),
+    ];
+
+    for (input_sql, expected_sql) in test_cases {
+        if let Some(expected) = expected_sql {
+            // Test that non-canonical order gets normalized
+            let parsed = snowflake().parse_sql_statements(input_sql).unwrap();
+            let formatted = parsed[0].to_string();
+            assert_eq!(formatted, expected, "Input: {}", input_sql);
+        } else {
+            // Test round-trip parsing
+            snowflake().verified_stmt(input_sql);
+        }
+    }
+}
+
+#[test]
+fn test_semantic_view_negative_cases() {
+    // Test invalid syntax that should fail
+    let invalid_sqls = [
+        "SELECT * FROM SEMANTIC_VIEW(model WHERE x > 0 DIMENSIONS dim1)",
+        "SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 WHERE x > 0 METRICS met1)",
+        "SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 DIMENSIONS dim2)",
+    ];
+
+    for sql in invalid_sqls {
+        let result = snowflake().parse_sql_statements(sql);
+        assert!(result.is_err(), "Expected error for invalid SQL: {}", sql);
+    }
+}
+
+#[test]
+fn test_semantic_view_ast_structure() {
+    // Test that we correctly parse into the expected AST structure
+    let sql = r#"SELECT * FROM SEMANTIC_VIEW(
+        my_model 
+        DIMENSIONS DATE_PART('year', date_col), region_name
+        METRICS SUM(revenue), COUNT(*)
+        WHERE active = true
+    ) AS model_alias"#;
+
+    let stmt = snowflake().parse_sql_statements(sql).unwrap();
+    match &stmt[0] {
+        Statement::Query(q) => {
+            if let SetExpr::Select(select) = q.body.as_ref() {
+                if let Some(TableWithJoins { relation, .. }) = select.from.first() {
+                    match relation {
+                        TableFactor::SemanticView {
+                            name,
+                            dimensions,
+                            metrics,
+                            facts,
+                            where_clause,
+                            alias,
+                        } => {
+                            assert_eq!(name.to_string(), "my_model");
+                            assert_eq!(dimensions.len(), 2);
+                            assert_eq!(dimensions[0].to_string(), "DATE_PART('year', date_col)");
+                            assert_eq!(dimensions[1].to_string(), "region_name");
+                            assert_eq!(metrics.len(), 2);
+                            assert_eq!(metrics[0].to_string(), "SUM(revenue)");
+                            assert_eq!(metrics[1].to_string(), "COUNT(*)");
+                            assert!(facts.is_empty());
+                            assert!(where_clause.is_some());
+                            assert_eq!(where_clause.as_ref().unwrap().to_string(), "active = true");
+                            assert!(alias.is_some());
+                            assert_eq!(alias.as_ref().unwrap().name.value, "model_alias");
+                        }
+                        _ => panic!("Expected SemanticView table factor"),
+                    }
+                } else {
+                    panic!("Expected table in FROM clause");
+                }
+            } else {
+                panic!("Expected SELECT statement");
+            }
+        }
+        _ => panic!("Expected Query statement"),
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -564,6 +564,10 @@ impl Dialect for SnowflakeDialect {`
`564`	`564`	`fn supports_select_wildcard_exclude(&self) -> bool {`
`565`	`565`	`true`
`566`	`566`	`}`
	`567`	`+`
	`568`	`+ fn supports_semantic_view(&self) -> bool {`
	`569`	`+ true`
	`570`	`+ }`
`567`	`571`	`}`
`568`	`572`
`569`	`573`	`// Peeks ahead to identify tokens that are expected after`