Minor Fixes #2
Merged
Minor Fixes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a RWMutex in in `header.go`, used in `writeSubset()` and `SortedKeyValues()`, in order to avoid any conflicts in the `exclude` map when several tasks are run, as suggested by @ShrimpAIO.
Fixed a couple typos in `README.md`, including the organization name in the link to the new repository (as pointed out by @0xflotus). Fixed the formatting in accordance with Google's Markdown Style Guide. Commented out the note at the beginning of the document without deleting it, as it is meant for the original repository owned by @zMrKrabz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request includes two minor changes, as shown by the two commits that form it.
The first change involves the introduction of a
RWMutexinheader.go, as @ShrimpAIO reported a Race Condition due toSortedKeyValues()andwriteSubset()both trying to access theexcludemap at the same time when running several tasks at once, resulting in a Fatal Error ("concurrent map read and map write").The second change mainly involves the modification of
README.md, formatting the document following Google's Markdown Style Guide. Additionally, the Note at the beginning of the file was commented out, as should only be used in @zMrKrabz's original repository. Finally, some spelling errors were corrected, including one pointed out by @0xflotus in this Open Pull Request.