Fix InsecureRequestWarning for HTTPS Emscripten requests (#3333)

Author: sethmlarson

changelog/3331.bugfix.rst

@@ -0,0 +1 @@
+Fixed issue where ``InsecureRequestWarning`` was emitted for HTTPS connections when using Emscripten.

src/urllib3/contrib/emscripten/connection.py

@@ -67,6 +67,7 @@ def __init__(
         self.blocksize = blocksize
         self.source_address = None
         self.socket_options = None
+        self.is_verified = False
 
     def set_tunnel(
         self,
@@ -228,6 +229,10 @@ def __init__(
 
         self.cert_reqs = None
 
+        # The browser will automatically verify all requests.
+        # We have no control over that setting.
+        self.is_verified = True
+
     def set_cert(
         self,
         key_file: str | None = None,

test/contrib/emscripten/test_emscripten.py

@@ -947,3 +947,28 @@ def count_calls(self, *args, **argv):  # type: ignore[no-untyped-def]
         assert count == 6
 
     pyodide_test(selenium_coverage, testserver_http.http_host, find_unused_port())
+
+
+@install_urllib3_wheel()
+def test_insecure_requests_warning(
+    selenium_coverage: typing.Any, testserver_http: PyodideServerInfo
+) -> None:
+    @run_in_pyodide  # type: ignore[misc]
+    def pyodide_test(selenium_coverage, host: str, port: int, https_port: int) -> None:  # type: ignore[no-untyped-def]
+        import warnings
+
+        import urllib3
+        import urllib3.exceptions
+
+        http = urllib3.PoolManager()
+
+        with warnings.catch_warnings(record=True) as w:
+            http.request("GET", f"https://{host}:{https_port}")
+        assert len(w) == 0
+
+    pyodide_test(
+        selenium_coverage,
+        testserver_http.http_host,
+        testserver_http.http_port,
+        testserver_http.https_port,
+    )