Support namespace packages without __init__.pyi files in typeshed #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunn1313
added a commit
to nipunn1313/typeshed
that referenced
this pull request
Oct 3, 2021
Since google is a namespace package, it won't have an init. Depends on typeshed-internal/stub_uploader#33
ilevkivskyi
approved these changes
Oct 3, 2021
Added a test to confirm it works. Also manually tested against protobuf package in typeshed.
JelleZijlstra
pushed a commit
to python/typeshed
that referenced
this pull request
Mar 20, 2022
Since google is a namespace package, it won't have an init. Depends on typeshed-internal/stub_uploader#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per python/peps#2083 and microsoft/pyright#2113 - looking to eliminate the
__init__.pyifile fromgoogle/in typeshed - since it's a namespace package.This adds support to the stub_uploader - including unit tests.
I also confirmed that it builds protobuf validly via running