Prefer @typescript-eslint/no-unused-expression (#450)

- Update converter for no-unused-expression to use the @typescript-eslint variation

Author: rwaskiewicz

src/rules/converters/no-unused-expression.ts

@@ -4,7 +4,7 @@ export const convertNoUnusedExpression: RuleConverter = (tslintRule) => {
     return {
         rules: [
             {
-                ruleName: "no-unused-expressions",
+                ruleName: "@typescript-eslint/no-unused-expressions",
                 ...collectNoticesAndArguments(tslintRule.ruleArguments),
             },
         ],

src/rules/converters/tests/no-unused-expression.test.ts

@@ -12,7 +12,7 @@ describe(convertNoUnusedExpression, () => {
                     notices: [
                         `The TSLint optional config "allow-new" is the default ESLint behavior and will no longer be ignored.`,
                     ],
-                    ruleName: "no-unused-expressions",
+                    ruleName: "@typescript-eslint/no-unused-expressions",
                 },
             ],
         });
@@ -30,7 +30,7 @@ describe(convertNoUnusedExpression, () => {
                         `The TSLint optional config "allow-new" is the default ESLint behavior and will no longer be ignored.`,
                     ],
                     ruleArguments: [{ allowShortCircuit: true }],
-                    ruleName: "no-unused-expressions",
+                    ruleName: "@typescript-eslint/no-unused-expressions",
                 },
             ],
         });
@@ -45,7 +45,7 @@ describe(convertNoUnusedExpression, () => {
             rules: [
                 {
                     ruleArguments: [{ allowTaggedTemplates: true }],
-                    ruleName: "no-unused-expressions",
+                    ruleName: "@typescript-eslint/no-unused-expressions",
                 },
             ],
         });
@@ -60,7 +60,7 @@ describe(convertNoUnusedExpression, () => {
             rules: [
                 {
                     ruleArguments: [{ allowShortCircuit: true }],
-                    ruleName: "no-unused-expressions",
+                    ruleName: "@typescript-eslint/no-unused-expressions",
                 },
             ],
         });
@@ -75,7 +75,7 @@ describe(convertNoUnusedExpression, () => {
             rules: [
                 {
                     ruleArguments: [{ allowTaggedTemplates: true, allowShortCircuit: true }],
-                    ruleName: "no-unused-expressions",
+                    ruleName: "@typescript-eslint/no-unused-expressions",
                 },
             ],
         });