Fix Go To Source Definition in --moduleResolution bundler

Author: andrewbranch

src/compiler/checker.ts

@@ -4149,7 +4149,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         if (!isIdentifier(name)) {
             return undefined;
         }
-        const suppressInteropError = name.escapedText === InternalSymbolName.Default && !!(compilerOptions.allowSyntheticDefaultImports || getESModuleInterop(compilerOptions));
+        const suppressInteropError = name.escapedText === InternalSymbolName.Default && !!(getAllowSyntheticDefaultImports(compilerOptions));
         const targetSymbol = resolveESModuleSymbol(moduleSymbol, moduleSpecifier, /*dontResolveAlias*/ false, suppressInteropError);
         if (targetSymbol) {
             if (name.escapedText) {
@@ -9204,7 +9204,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 // If `target` refers to a shorthand module symbol, the name we're trying to pull out isn;t recoverable from the target symbol
                 // In such a scenario, we must fall back to looking for an alias declaration on `symbol` and pulling the target name from that
                 let verbatimTargetName = isShorthandAmbientModuleSymbol(target) && getSomeTargetNameFromDeclarations(symbol.declarations) || unescapeLeadingUnderscores(target.escapedName);
-                if (verbatimTargetName === InternalSymbolName.ExportEquals && (getESModuleInterop(compilerOptions) || compilerOptions.allowSyntheticDefaultImports)) {
+                if (verbatimTargetName === InternalSymbolName.ExportEquals && getAllowSyntheticDefaultImports(compilerOptions)) {
                     // target refers to an `export=` symbol that was hoisted into a synthetic default - rename here to match
                     verbatimTargetName = InternalSymbolName.Default;
                 }
@@ -34163,7 +34163,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         }
 
         // In JavaScript files, calls to any identifier 'require' are treated as external module imports
-        if (isInJSFile(node) && getEmitModuleResolutionKind(compilerOptions) !== ModuleResolutionKind.Bundler && isCommonJsRequire(node)) {
+        if (isInJSFile(node) && (getEmitModuleResolutionKind(compilerOptions) !== ModuleResolutionKind.Bundler || compilerOptions.noDtsResolution) && isCommonJsRequire(node)) {
+            // `bundler` doesn't support resolving `require`, but needs to in `noDtsResolution` to support Find Source Definition
             return resolveExternalModuleTypeByLiteral(node.arguments![0] as StringLiteral);
         }
 

tests/cases/fourslash/server/goToSource15_bundler.ts

@@ -0,0 +1,34 @@
+/// <reference path="../fourslash.ts" />
+
+// @Filename: /tsconfig.json
+//// { "compilerOptions": { "module": "esnext", "moduleResolution": "bundler" } }
+
+// @Filename: /node_modules/react/package.json
+//// { "name": "react", "version": "16.8.6", "main": "index.js" }
+
+// @Filename: /node_modules/react/index.js
+//// 'use strict';
+//// 
+//// if (process.env.NODE_ENV === 'production') {
+////   module.exports = require('./cjs/react.production.min.js');
+//// } else {
+////   module.exports = require('./cjs/react.development.js');
+//// }
+
+// @Filename: /node_modules/react/cjs/react.production.min.js
+//// 'use strict';exports./*production*/useState=function(a){};exports.version='16.8.6';
+
+// @Filename: /node_modules/react/cjs/react.development.js
+//// 'use strict';
+//// if (process.env.NODE_ENV !== 'production') {
+////   (function() {
+////     function useState(initialState) {}
+////     exports./*development*/useState = useState;
+////     exports.version = '16.8.6';
+////   }());
+//// }
+
+// @Filename: /index.ts
+//// import { [|/*start*/useState|] } from 'react';
+
+verify.baselineGoToSourceDefinition("start");