Skip to content

Commit e37cef0

Browse files
authored
Make RelatedManager, ManyRelatedManager to inherit from Manager not BaseManager (#1843)
* Restore RelatedManager inheritance from Manager * Switch ManyRelatedManager to inherit from Manager
1 parent 1a59756 commit e37cef0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

django-stubs/db/models/fields/related_descriptors.pyi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ from django.db.models.base import Model
66
from django.db.models.fields import Field
77
from django.db.models.fields.related import ForeignKey, ManyToManyField, RelatedField
88
from django.db.models.fields.reverse_related import ManyToManyRel, ManyToOneRel, OneToOneRel
9-
from django.db.models.manager import BaseManager
9+
from django.db.models.manager import BaseManager, Manager
1010
from django.db.models.query import QuerySet
1111
from django.db.models.query_utils import DeferredAttribute
1212
from django.utils.functional import cached_property
@@ -88,7 +88,7 @@ class ReverseManyToOneDescriptor:
8888
def __set__(self, instance: Any, value: Any) -> NoReturn: ...
8989

9090
# Fake class, Django defines 'RelatedManager' inside a function body
91-
class RelatedManager(BaseManager[_M], Generic[_M]):
91+
class RelatedManager(Manager[_M], Generic[_M]):
9292
related_val: tuple[int, ...]
9393
def add(self, *objs: _M | int, bulk: bool = ...) -> None: ...
9494
async def aadd(self, *objs: _M | int, bulk: bool = ...) -> None: ...
@@ -126,7 +126,7 @@ class ManyToManyDescriptor(ReverseManyToOneDescriptor, Generic[_M]):
126126
def related_manager_cls(self) -> type[ManyRelatedManager[Any]]: ... # type: ignore[override]
127127

128128
# Fake class, Django defines 'ManyRelatedManager' inside a function body
129-
class ManyRelatedManager(BaseManager[_M], Generic[_M]):
129+
class ManyRelatedManager(Manager[_M], Generic[_M]):
130130
related_val: tuple[int, ...]
131131
def add(self, *objs: _M | int, bulk: bool = ...) -> None: ...
132132
async def aadd(self, *objs: _M | int, bulk: bool = ...) -> None: ...

0 commit comments

Comments
 (0)