Skip to content

Avoid an infinite loop when requesting compiler options #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Avoid an infinite loop when requesting compiler options #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/incremental-typescript-compiler/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ module.exports = class IncrementalTypescriptCompiler {

this._ts = project.require('typescript');
this._watchProgram = null;
this._compilerOptions = null;
}

treeForHost() {
Expand Down Expand Up @@ -115,6 +116,10 @@ module.exports = class IncrementalTypescriptCompiler {
}
}
});

// Prefetch the compiler options, because fetching them while reporting a diagnostic
// can result in a diagnostic-reporting loop in certain states
this._compilerOptions = this.getProgram().getCompilerOptions();
}

getProgram() {
Expand All @@ -130,8 +135,7 @@ module.exports = class IncrementalTypescriptCompiler {
}

_shouldFailOnTypeError() {
let options = this.getProgram().getCompilerOptions();
return !!options.noEmitOnError;
return !!this._compilerOptions.noEmitOnError;
}

_mirageDirectory() {
Expand Down