Simplify watcher #196
Merged
Simplify watcher #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@tansongyang given our history with this particular code, if you happen to have a chance to try out this branch at some point before it's merged, that would be wonderful 🙂 |
Contributor
|
@dfreeman Apologies for the late response! I got back from our engineering offsite last night. I just tried this branch out and everything is A-OK. |
Member
|
|
jamescdavis
reviewed
Apr 26, 2018
| extendedDiagnostics: debug.enabled | ||
| }, tsOptions); | ||
|
|
||
| let ts = project.require('typescript'); |
jamescdavis
approved these changes
Apr 26, 2018
Member
jamescdavis
left a comment
jamescdavis
left a comment
There was a problem hiding this comment.
Tested with our app and this works great!
Member
Author
|
Great! I'll plan to merge and cut another beta release later today. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked some over the weekend on an implementation of #192, and in the process put the new watcher implementation through its paces. I found a couple scenarios (e.g. deleting a whole tree of directories) where the compiler would wind up hanging on to an orphaned reference to a file that no longer existed, and after comparing diagnostic output between our watcher and one of the default implementations, realized that their directory watcher was much more active than ours.
It seems with our chokidar setup we can forgo
watchFilecompletely and just trigger thewatchDirectorycallback whenever a file within that directory changes. This eliminated all of the weird behavior I'd been seeing, and it got tsc's diagnostic output when using our watcher inline with what you'd see from the default one.