Skip to content

Conversation

@mskelton
Copy link
Contributor

Re-opening #238 given the new import attributes spec is at stage 3.

tc39/ecma262#3057

Checklist:

  • All tests pass in CI.
  • The script/parse-examples passes without issues.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@mskelton mskelton mentioned this pull request Dec 14, 2023
6 tasks
@amaanq amaanq mentioned this pull request Feb 1, 2024
@amaanq
Copy link
Member

amaanq commented Feb 1, 2024

Hi @mskelton, I cherry picked your changes onto #291, thank you!

@amaanq amaanq closed this Feb 1, 2024
@mskelton mskelton deleted the import-attributes branch February 1, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants