refactor: move completion messages to main execution flow

- Move final completion message from Ansible verification back to main execute() method
- Ensure proper message flow and output flushing
- Improve E2E test error reporting with output on failure
- Switch Ansible to JSON output to prevent TAP conflicts

This completes the refactoring that removed 109 lines of redundant
verification code and replaces custom SSH verification with Ansible-based
post-provision verification.

Author: josecelano

lib/TorrustDeploy/App/Command/Provision.pm

@@ -55,6 +55,7 @@ sub execute {
 
     # Get VM IP address
     my $vm_ip = $tofu->get_vm_ip($tofu_dir);
+    STDOUT->flush();
 
     # Create SSH connection
     my $ssh_connection = TorrustDeploy::Infrastructure::SSH::Connection->new(host => $vm_ip);
@@ -64,6 +65,13 @@ sub execute {
 
     # Run Ansible post-provision verification
     $self->_run_ansible_verification($vm_ip, $work_dir);
+
+    # Final completion message
+    say "";
+    say "✅ Provisioning completed successfully!";
+    say "VM is ready at IP: " . $vm_ip;
+    say "You can connect using: ssh -i ~/.ssh/testing_rsa torrust@" . $vm_ip;
+    STDOUT->flush();
 }
 
 sub _copy_templates {
@@ -278,13 +286,6 @@ sub _run_ansible_verification {
 
     # Run verification playbook
     $ansible->run_verification($ansible_dir);
-    
-    # Final completion message
-    say "";
-    say "✅ Provisioning completed successfully!";
-    say "VM is ready at IP: $vm_ip";
-    say "You can connect using: ssh -i ~/.ssh/testing_rsa torrust@$vm_ip";
-    STDOUT->flush();
 }
 
 1;

t/e2e/provision.t

@@ -127,8 +127,8 @@ subtest 'provision command executes successfully' => sub {
 
     note "Provision command completed in ${duration} seconds";
 
-    # Show output summary in verbose mode
-    if ($ENV{TEST_VERBOSE} || $ENV{HARNESS_IS_VERBOSE}) {
+    # Show output summary in verbose mode or on failure
+    if ($ENV{TEST_VERBOSE} || $ENV{HARNESS_IS_VERBOSE} || $exit_code != 0) {
         note "Command output (last 50 lines):";
         my @output_lines = split /\n/, $output;
         my $start_line = @output_lines > 50 ? @output_lines - 50 : 0;
@@ -140,6 +140,16 @@ subtest 'provision command executes successfully' => sub {
     # Command should complete successfully
     is($exit_code, 0, 'provision command exits with status 0');
 
+    # Show helpful message on failure
+    if ($exit_code != 0) {
+        note "Provision command failed with exit code: $exit_code";
+        note "Check the output above for details. Common issues:";
+        note "  - SSH connectivity problems";
+        note "  - Ansible execution failures";
+        note "  - VM creation timeouts";
+        note "  - Cloud-init completion issues";
+    }
+    
     # Basic checks - we can't easily check output without complexity
     pass('provision command executed (use prove -v to see output)');
     pass('provision completed within timeout');

templates/ansible/ansible.cfg

@@ -5,7 +5,7 @@ remote_user = torrust
 private_key_file = ~/.ssh/testing_rsa
 host_key_checking = False
 retry_files_enabled = False
-stdout_callback = yaml
+stdout_callback = json
 gathering = smart
 fact_caching = memory