feat: [#1] improve API error reporting and complete token standardization

This commit completes the replacement of 'local-dev-admin-token-12345' with
'MyAccessToken' across all components and improves error reporting for API
endpoint failures.

Changes:
- Replace old token with MyAccessToken in documentation (integration-testing-guide.md, smoke-testing-guide.md)
- Replace old token with MyAccessToken in test scripts (test-e2e.sh)
- Improve API endpoint error reporting in deploy-app.sh and health-check.sh
  - Show HTTP status code and response body on API failures
  - Use proper HTTP status checking and temp file handling
- Fix ShellCheck linting issues with variable assignments and comparisons

Benefits:
- API authentication failures now show actual error details
- Consistent token usage across all environments and documentation
- Better debugging capabilities for deployment issues
- Cleaner code that passes linting validation

Testing:
- Validated API endpoint works with MyAccessToken
- Confirmed error reporting shows detailed failure information
- E2E tests now use standardized token consistently

Author: josecelano

docs/guides/integration-testing-guide.md

@@ -1199,7 +1199,7 @@ curl -s http://$VM_IP/api/health_check | jq .
 
 # [PROJECT_ROOT] Test stats API (requires authentication token)
 # Note: Get the token from the .env file in the VM
-TOKEN="local-dev-admin-token-12345"
+TOKEN="MyAccessToken"
 curl -s "http://$VM_IP/api/v1/stats?token=$TOKEN" | jq .
 ```
 
@@ -1289,7 +1289,7 @@ curl http://$VM_IP/prometheus/                # Prometheus UI
 ssh torrust@$VM_IP \
   "grep TRACKER_ADMIN_TOKEN /home/torrust/github/torrust/torrust-tracker-demo/application/.env"
 
-# Should output: TRACKER_ADMIN_TOKEN=local-dev-admin-token-12345
+# Should output: TRACKER_ADMIN_TOKEN=MyAccessToken
 ```
 
 #### 5.2.5 Advanced Testing with jq
@@ -1700,10 +1700,10 @@ VM_IP=$(cd infrastructure/terraform && tofu output -raw vm_ip)
 curl -s http://$VM_IP/api/health_check | jq .
 
 # Test stats (auth required)
-curl -s "http://$VM_IP/api/v1/stats?token=local-dev-admin-token-12345" | jq .
+curl -s "http://$VM_IP/api/v1/stats?token=MyAccessToken" | jq .
 
 # Test specific metrics with jq filtering
-curl -s "http://$VM_IP/api/v1/stats?token=local-dev-admin-token-12345" | jq '.torrents, .seeders, .leechers'
+curl -s "http://$VM_IP/api/v1/stats?token=MyAccessToken" | jq '.torrents, .seeders, .leechers'
 ```
 
 #### ✅ Monitoring Service Testing
@@ -1751,7 +1751,7 @@ curl http://$VM_IP/api/v1/stats
 **Correct**: Including authentication token:
 
 ```bash
-curl "http://$VM_IP/api/v1/stats?token=local-dev-admin-token-12345"
+curl "http://$VM_IP/api/v1/stats?token=MyAccessToken"
 ```
 
 ### 9.4 Health Check Limitations
@@ -2054,7 +2054,7 @@ During the most recent testing cycle, the following components were validated su
 
 - **Health Check API**: `/api/health_check` - No authentication required
 - **Stats API**: `/api/v1/stats` - **Requires authentication token**
-- **Admin Token**: `local-dev-admin-token-12345` (from `.env` file)
+- **Admin Token**: `MyAccessToken` (from `.env` file)
 
 #### Correct API Testing Examples
 
@@ -2063,7 +2063,7 @@ During the most recent testing cycle, the following components were validated su
 curl -s http://$VM_IP/api/health_check | jq .
 
 # Stats API (auth required)
-curl -s "http://$VM_IP/api/v1/stats?token=local-dev-admin-token-12345" | jq .
+curl -s "http://$VM_IP/api/v1/stats?token=MyAccessToken" | jq .
 ```
 
 #### Network Architecture

docs/guides/smoke-testing-guide.md

@@ -267,7 +267,7 @@ The statistics API is available through the nginx proxy on port 80:
 ```bash
 # Test statistics API through nginx proxy (requires admin token)
 echo "=== Testing Statistics API ==="
-curl -s "http://$TARGET_SERVER:80/api/v1/stats?token=local-dev-admin-token-12345" | jq
+curl -s "http://$TARGET_SERVER:80/api/v1/stats?token=MyAccessToken" | jq
 ```
 
 **Expected Output:**

infrastructure/scripts/deploy-app.sh

@@ -483,12 +483,21 @@ validate_deployment() {
         fi
         
         # Test API stats endpoint (through nginx proxy, requires auth)
-        if curl -f -s "http://localhost/api/v1/stats?token=local-dev-admin-token-12345" >/dev/null 2>&1; then
+        # Save response to temp file and get HTTP status code
+        api_http_code=\$(curl -s -o /tmp/api_response.json -w '%{http_code}' \"http://localhost/api/v1/stats?token=MyAccessToken\" 2>&1 || echo \"000\")
+        api_response_body=\$(cat /tmp/api_response.json 2>/dev/null || echo \"No response\")
+        
+        # Check if HTTP status is 200 (success)
+        if [ \"\$api_http_code\" -eq 200 ] 2>/dev/null; then
             echo '✅ API stats endpoint: OK'
         else
             echo '❌ API stats endpoint: FAILED'
+            echo \"  HTTP Code: \$api_http_code\"
+            echo \"  Response: \$api_response_body\"
+            rm -f /tmp/api_response.json
             exit 1
         fi
+        rm -f /tmp/api_response.json
         
         # Test HTTP tracker endpoint (through nginx proxy - expects 404 for root)
         if curl -s -w '%{http_code}' http://localhost/ -o /dev/null | grep -q '404'; then
@@ -516,7 +525,7 @@ show_connection_info() {
     echo
     echo "=== APPLICATION ENDPOINTS ==="
     echo "Health Check:    http://${vm_ip}/health_check"                                   # DevSkim: ignore DS137138
-    echo "API Stats:       http://${vm_ip}/api/v1/stats?token=local-dev-admin-token-12345" # DevSkim: ignore DS137138
+    echo "API Stats:       http://${vm_ip}/api/v1/stats?token=MyAccessToken" # DevSkim: ignore DS137138
     echo "HTTP Tracker:    http://${vm_ip}/ (for BitTorrent clients)"                      # DevSkim: ignore DS137138
     echo "UDP Tracker:     udp://${vm_ip}:6868, udp://${vm_ip}:6969"
     echo "Grafana:         http://${vm_ip}:3100 (admin/admin)" # DevSkim: ignore DS137138

infrastructure/scripts/health-check.sh

@@ -142,19 +142,23 @@ test_application_endpoints() {
 
     # Test API stats endpoint (via nginx proxy with auth)
     ((TOTAL_TESTS++))
-    if vm_exec "${vm_ip}" "curl -f -s 'http://localhost/api/v1/stats?token=local-dev-admin-token-12345' >/dev/null 2>&1"; then
+    local api_response
+    local api_http_code
+    api_response=$(vm_exec "${vm_ip}" "curl -s -w '\\n%{http_code}' 'http://localhost/api/v1/stats?token=MyAccessToken'" || echo "")
+    api_http_code=$(echo "${api_response}" | tail -n1)
+    api_response=$(echo "${api_response}" | head -n -1)
+
+    if [[ "${api_http_code}" == "200" ]]; then
         log_test_pass "API stats endpoint (nginx proxy)"
 
         # Get stats if verbose
         if [[ "${VERBOSE}" == "true" ]]; then
-            local stats
-            stats=$(vm_exec "${vm_ip}" "curl -s 'http://localhost/api/v1/stats?token=local-dev-admin-token-12345'" || echo "")
-            if [[ -n "${stats}" ]]; then
-                echo "  Stats: ${stats}"
-            fi
+            echo "  Stats: ${api_response}"
         fi
     else
         log_test_fail "API stats endpoint (nginx proxy)"
+        echo "  HTTP Code: ${api_http_code}"
+        echo "  Response: ${api_response}"
     fi
 
     # Test HTTP tracker endpoint (via nginx proxy - expects 404 for root)

tests/test-e2e.sh

@@ -234,7 +234,7 @@ test_smoke_testing() {
 
     # Test 2: Statistics API (through nginx proxy on port 80)
     log_info "Testing statistics API through nginx proxy..."
-    if [[ $(test_http_endpoint "http://${vm_ip}:80/api/v1/stats?token=local-dev-admin-token-12345" '"torrents"') == "success" ]]; then # DevSkim: ignore DS137138
+    if [[ $(test_http_endpoint "http://${vm_ip}:80/api/v1/stats?token=MyAccessToken" '"torrents"') == "success" ]]; then # DevSkim: ignore DS137138
         log_success "✓ Statistics API working"
     else
         log_error "✗ Statistics API failed"
@@ -521,7 +521,7 @@ run_e2e_test() {
         return 0
     else
         log_section "TEST RESULT: FAILURE"
-        log_error "End-to-end twelve-factor deployment test failed!"
+        log_error "End-to-end test failed!"
         log_error "Total test time: ${minutes}m ${seconds}s"
         log_error "Check test log for details: ${TEST_LOG_FILE}"
         return 1