refactor: move nginx.conf to infrastructure templates and improve configuration management

- Move nginx.conf template from application/share/container/default/config/ to infrastructure/config/templates/nginx.conf.tpl
- Update install.sh to only verify nginx.conf exists (not create it)
- Update infrastructure/scripts/configure-env.sh to generate nginx.conf from template
- Add application/storage cleanup to clean-and-fix target with user confirmation
- Improve separation of concerns: infrastructure manages templates, application verifies files exist
- Follow 12-factor principles: configuration is generated by infrastructure, not application

This ensures the nginx.conf file is always generated with the latest configuration
and integration tests work properly with clean application/storage directories.

Author: josecelano

Makefile

@@ -189,7 +189,23 @@ clean-and-fix: ## Clean up all VMs and fix libvirt permissions
 	@cd $(TERRAFORM_DIR) && rm -f terraform.tfstate terraform.tfstate.backup .terraform.lock.hcl 2>/dev/null || true
 	@echo "3. Cleaning libvirt images:"
 	@sudo rm -f /var/lib/libvirt/images/torrust-tracker-demo* /var/lib/libvirt/images/ubuntu-24.04-base.qcow2 2>/dev/null || true
-	@echo "4. Fixing libvirt setup:"
+	@echo "4. Cleaning application storage (generated configuration files):"
+	@if [ -d "application/storage" ]; then \
+		echo "   WARNING: This will delete all generated configuration files in application/storage/"; \
+		echo "   This includes nginx configs, tracker configs, and any cached data."; \
+		echo "   These files will be regenerated when you run 'make configure-local'."; \
+		read -p "   Do you want to delete application/storage? (y/N): " confirm; \
+		if [ "$$confirm" = "y" ] || [ "$$confirm" = "Y" ]; then \
+			echo "   Removing application/storage..."; \
+			rm -rf application/storage; \
+			echo "   ✓ Application storage cleaned"; \
+		else \
+			echo "   Skipping application/storage cleanup"; \
+		fi; \
+	else \
+		echo "   No application/storage directory found"; \
+	fi
+	@echo "5. Fixing libvirt setup:"
 	@$(MAKE) fix-libvirt
 	@echo "✓ Clean up complete. You can now run 'make apply' safely."
 

application/share/bin/install.sh

@@ -23,11 +23,20 @@ mkdir -p ./storage/proxy/etc/nginx-conf
 mkdir -p ./storage/proxy/webroot
 mkdir -p ./storage/dhparam
 
+# Verify nginx configuration exists (should be provided by infrastructure)
 if ! [ -f "./storage/proxy/etc/nginx-conf/nginx.conf" ]; then
-	echo "Creating proxy config file: './storage/proxy/etc/nginx-conf/nginx.conf'"
-	cp ./share/container/default/config/nginx.conf ./storage/proxy/etc/nginx-conf/nginx.conf
+	echo "ERROR: Nginx configuration file './storage/proxy/etc/nginx-conf/nginx.conf' not found!"
+	echo "This file should be generated by the infrastructure configuration system."
+	echo "Expected location: $(pwd)/storage/proxy/etc/nginx-conf/nginx.conf"
+	echo ""
+	echo "To generate the configuration file, run:"
+	echo "  make configure-local    # For local development"
+	echo "  make configure-production # For production deployment"
+	exit 1
 fi
 
+echo "Found nginx configuration: ./storage/proxy/etc/nginx-conf/nginx.conf"
+
 ## Certbot
 
 mkdir -p ./storage/certbot/etc

docs/guides/integration-testing-guide.md

@@ -1548,7 +1548,7 @@ This guide provides a complete integration testing workflow that:
 This guide provides a complete integration testing workflow that:
 
 1. **Creates fresh infrastructure** in ~3-5 minutes
-2. **Generates configuration files** from templates (~2 seconds)  
+2. **Generates configuration files** from templates (~2 seconds)
 3. **Refreshes OpenTofu state** to detect VM IP (~3 seconds)
 4. **Waits for cloud-init** to complete (~2-3 minutes)
 5. **Runs comprehensive tests** covering all services (~3-5 minutes)
@@ -1565,10 +1565,10 @@ During the most recent testing cycle, the following components were validated su
 #### Infrastructure Tests
 
 - ✅ **VM Access**: SSH connectivity working at `192.168.122.54`
-- ✅ **Docker Installation**: Docker 28.3.1 and Docker Compose V2.38.1 working  
+- ✅ **Docker Installation**: Docker 28.3.1 and Docker Compose V2.38.1 working
 - ✅ **Service Health**: All containers running with healthy status
 
-#### Service Deployment  
+#### Service Deployment
 
 - ✅ **MySQL**: Database running healthy with proper credentials
 - ✅ **Tracker**: Torrust Tracker running with all endpoints active
@@ -1603,7 +1603,7 @@ During the most recent testing cycle, the following components were validated su
 # Health check (no auth needed)
 curl -s http://$VM_IP/api/health_check | jq .
 
-# Stats API (auth required) 
+# Stats API (auth required)
 curl -s "http://$VM_IP/api/v1/stats?token=local-dev-admin-token-12345" | jq .
 ```
 

application/share/container/default/config/nginx.conf renamed to infrastructure/config/templates/nginx.conf.tpl

@@ -141,6 +141,15 @@ process_templates() {
         log_info "Generated: ${prometheus_output_dir}/prometheus.yml"
     fi
 
+    # Process nginx configuration template
+    if [[ -f "${templates_dir}/nginx.conf.tpl" ]]; then
+        log_info "Processing nginx configuration template"
+        local nginx_output_dir="${PROJECT_ROOT}/application/storage/proxy/etc/nginx-conf"
+        mkdir -p "${nginx_output_dir}"
+        envsubst <"${templates_dir}/nginx.conf.tpl" >"${nginx_output_dir}/nginx.conf"
+        log_info "Generated: ${nginx_output_dir}/nginx.conf"
+    fi
+
     log_success "Configuration templates processed"
 }