Phase 1: Infrastructure scope reduction for configure-env.sh

- Remove application configuration processing functions:
  * validate_ssl_configuration()
  * validate_backup_configuration()
  * process_templates()
  * generate_docker_env()
- Update main() function to focus on infrastructure-only configuration
- Enhance help text to clarify infrastructure-only purpose
- Preserve core infrastructure functionality:
  * Environment validation (development, testing, e2e, staging, production)
  * Provider validation (hetzner, libvirt)
  * Infrastructure *.env file generation
  * Production secrets generation

Script now handles only infrastructure configuration generation,
separating concerns as documented in ADR-008 and the 6-phase
refactoring plan. Application configuration will be handled
by separate scripts in subsequent phases.

Relates to: Issue #28 Phase 4 Hetzner infrastructure implementation
Implements: Configuration Architecture Standardization Phase 1

Author: josecelano

infrastructure/scripts/configure-env.sh

@@ -351,174 +351,12 @@ validate_environment() {
         fi
     done
 
-    # Validate SSL configuration variables
-    validate_ssl_configuration
-
-    # Validate backup configuration variables
-    validate_backup_configuration
-
     log_success "Environment validation passed"
 }
 
-# Validate SSL certificate configuration
-validate_ssl_configuration() {
-    # Check if TRACKER_DOMAIN is set and not a placeholder
-    if [[ -z "${TRACKER_DOMAIN:-}" ]]; then
-        log_error "SSL configuration: TRACKER_DOMAIN is not set"
-        exit 1
-    fi
-    
-    if [[ "${TRACKER_DOMAIN}" == "REPLACE_WITH_YOUR_DOMAIN" ]]; then
-        log_error "SSL configuration: TRACKER_DOMAIN contains placeholder value 'REPLACE_WITH_YOUR_DOMAIN'"
-        log_error "Please edit your environment file and set a real domain name"
-        exit 1
-    fi
-
-    # Check if CERTBOT_EMAIL is set and not a placeholder
-    if [[ -z "${CERTBOT_EMAIL:-}" ]]; then
-        log_error "SSL configuration: CERTBOT_EMAIL is not set"
-        exit 1
-    fi
-    
-    if [[ "${CERTBOT_EMAIL}" == "REPLACE_WITH_YOUR_EMAIL" ]]; then
-        log_error "SSL configuration: CERTBOT_EMAIL contains placeholder value 'REPLACE_WITH_YOUR_EMAIL'"
-        log_error "Please edit your environment file and set a real email address"
-        exit 1
-    fi
-
-    # Validate email format (basic validation)
-    if [[ ! "${CERTBOT_EMAIL}" =~ ^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$ ]]; then
-        log_error "SSL configuration: CERTBOT_EMAIL '${CERTBOT_EMAIL}' is not a valid email format"
-        exit 1
-    fi
-
-    # Check if ENABLE_SSL is a valid boolean
-    if [[ -z "${ENABLE_SSL:-}" ]]; then
-        log_error "SSL configuration: ENABLE_SSL is not set"
-        exit 1
-    fi
-    
-    if [[ "${ENABLE_SSL}" != "true" && "${ENABLE_SSL}" != "false" ]]; then
-        log_error "SSL configuration: ENABLE_SSL must be 'true' or 'false', got '${ENABLE_SSL}'"
-        exit 1
-    fi
-
-    # Log SSL configuration validation result
-    if [[ "${ENABLE_SSL}" == "true" ]]; then
-        log_info "SSL configuration: Enabled for domain '${TRACKER_DOMAIN}' with email '${CERTBOT_EMAIL}'"
-    else
-        log_info "SSL configuration: Disabled (ENABLE_SSL=false)"
-    fi
-}
-
-# Validate backup configuration
-validate_backup_configuration() {
-    # Check if ENABLE_DB_BACKUPS is a valid boolean
-    if [[ -z "${ENABLE_DB_BACKUPS:-}" ]]; then
-        log_error "Backup configuration: ENABLE_DB_BACKUPS is not set"
-        exit 1
-    fi
-    
-    if [[ "${ENABLE_DB_BACKUPS}" != "true" && "${ENABLE_DB_BACKUPS}" != "false" ]]; then
-        log_error "Backup configuration: ENABLE_DB_BACKUPS must be 'true' or 'false', got '${ENABLE_DB_BACKUPS}'"
-        exit 1
-    fi
-
-    # Validate BACKUP_RETENTION_DAYS is numeric and reasonable
-    if [[ -z "${BACKUP_RETENTION_DAYS:-}" ]]; then
-        log_error "Backup configuration: BACKUP_RETENTION_DAYS is not set"
-        exit 1
-    fi
-    
-    if ! [[ "${BACKUP_RETENTION_DAYS}" =~ ^[0-9]+$ ]]; then
-        log_error "Backup configuration: BACKUP_RETENTION_DAYS must be a positive integer, got '${BACKUP_RETENTION_DAYS}'"
-        exit 1
-    fi
-    
-    if [[ "${BACKUP_RETENTION_DAYS}" -lt 1 ]]; then
-        log_error "Backup configuration: BACKUP_RETENTION_DAYS must be at least 1 day, got '${BACKUP_RETENTION_DAYS}'"
-        exit 1
-    fi
-    
-    if [[ "${BACKUP_RETENTION_DAYS}" -gt 365 ]]; then
-        log_warning "Backup configuration: BACKUP_RETENTION_DAYS is very high (${BACKUP_RETENTION_DAYS} days)"
-        log_warning "This may consume significant disk space"
-    fi
-
-    # Log backup configuration validation result
-    if [[ "${ENABLE_DB_BACKUPS}" == "true" ]]; then
-        log_info "Backup configuration: Enabled with ${BACKUP_RETENTION_DAYS} days retention"
-    else
-        log_info "Backup configuration: Disabled (ENABLE_DB_BACKUPS=false)"
-    fi
-}
-
-# Process configuration templates
-process_templates() {
-    local templates_dir="${CONFIG_DIR}/templates"
-    local output_dir="${PROJECT_ROOT}/application/storage/tracker/etc"
-
-    # Ensure output directory exists
-    mkdir -p "${output_dir}"
-
-    # Process tracker configuration template
-    if [[ -f "${templates_dir}/application/tracker.toml.tpl" ]]; then
-        log_info "Processing tracker configuration template"
-        envsubst <"${templates_dir}/application/tracker.toml.tpl" >"${output_dir}/tracker.toml"
-        log_info "Generated: ${output_dir}/tracker.toml"
-    fi
-
-    # Process prometheus configuration template
-    if [[ -f "${templates_dir}/application/prometheus.yml.tpl" ]]; then
-        log_info "Processing prometheus configuration template"
-        local prometheus_output_dir="${PROJECT_ROOT}/application/storage/prometheus/etc"
-        mkdir -p "${prometheus_output_dir}"
-        envsubst <"${templates_dir}/application/prometheus.yml.tpl" >"${prometheus_output_dir}/prometheus.yml"
-        log_info "Generated: ${prometheus_output_dir}/prometheus.yml"
-    fi
-
-    # Process nginx configuration template
-    if [[ -f "${templates_dir}/application/nginx/nginx.conf.tpl" ]]; then
-        log_info "Processing nginx configuration template"
-        local nginx_output_dir="${PROJECT_ROOT}/application/storage/proxy/etc/nginx-conf"
-        mkdir -p "${nginx_output_dir}"
-        envsubst <"${templates_dir}/application/nginx/nginx.conf.tpl" >"${nginx_output_dir}/nginx.conf"
-        log_info "Generated: ${nginx_output_dir}/nginx.conf"
-    fi
-
-    log_success "Configuration templates processed"
-}
-
-# Generate .env file for Docker Compose
-generate_docker_env() {
-    local templates_dir="${CONFIG_DIR}/templates"
-    local env_output="${PROJECT_ROOT}/application/storage/compose/.env"
-
-    log_info "Generating Docker Compose environment file"
-
-    # Ensure the storage/compose directory exists
-    mkdir -p "$(dirname "${env_output}")"
-
-    # Set generation date for template
-    GENERATION_DATE="$(TZ=UTC date)"
-    export GENERATION_DATE
-
-    # Ensure ENVIRONMENT is exported for template substitution
-    export ENVIRONMENT
-
-    # Process Docker Compose environment template
-    if [[ -f "${templates_dir}/application/docker-compose.env.tpl" ]]; then
-        envsubst <"${templates_dir}/application/docker-compose.env.tpl" >"${env_output}"
-        log_info "Generated: ${env_output}"
-    else
-        log_error "Docker Compose environment template not found: ${templates_dir}/application/docker-compose.env.tpl"
-        exit 1
-    fi
-}
-
 # Main execution
 main() {
-    log_info "Starting configuration generation for environment type: ${ENVIRONMENT} with provider: ${PROVIDER}"
+    log_info "Starting infrastructure configuration generation for environment type: ${ENVIRONMENT} with provider: ${PROVIDER}"
 
     # Validate inputs
     validate_environment_type "${ENVIRONMENT}"
@@ -527,24 +365,34 @@ main() {
     # Generate environment configuration
     generate_environment_config "${ENVIRONMENT}" "${PROVIDER}" "${OUTPUT_NAME}"
 
-    log_success "Configuration generation completed successfully"
+    log_success "Infrastructure configuration generation completed successfully"
     log_info "Generated file: infrastructure/config/environments/${OUTPUT_NAME}.env"
+    log_info ""
+    log_info "Next steps:"
+    log_info "  1. Review and customize the generated environment file"
+    log_info "  2. Run infrastructure deployment: make infra-apply ENVIRONMENT=${ENVIRONMENT} ENVIRONMENT_FILE=${OUTPUT_NAME}"
+    log_info "  3. Generate application configuration: make app-config ENVIRONMENT=${ENVIRONMENT} ENVIRONMENT_FILE=${OUTPUT_NAME}"
 }
 
 # Show help
 show_help() {
     cat <<EOF
-Environment Configuration Generator
+Infrastructure Environment Configuration Generator
 
 Usage: $0 <ENVIRONMENT> <PROVIDER> [OUTPUT_NAME]
 
+Description:
+    Generates infrastructure environment configuration files (*.env) for deploying
+    the Torrust Tracker Demo infrastructure. This script handles only infrastructure
+    configuration - application configuration is handled separately.
+
 Arguments:
     ENVIRONMENT         Environment type: development, testing, e2e, staging, production
     PROVIDER           Provider name (from infrastructure/config/providers/*.env)
     OUTPUT_NAME        Optional custom output filename (default: {environment}-{provider})
 
 Environment Types:
-    development        Local development environment
+    development        Local development environment (libvirt/KVM)
     testing           General testing environment (reserved for future use)
     e2e               End-to-end testing environment
     staging           Pre-production staging environment
@@ -575,9 +423,17 @@ Generated Files:
     - All files include ENVIRONMENT and PROVIDER variables for identification
 
 Note:
+    This script only generates infrastructure environment configuration files.
+    For application configuration, use the application configuration scripts.
     Users can create any number of environment files with custom names.
     The application identifies environment type and provider from variables inside the file,
     not from the filename.
+
+Workflow:
+    1. Generate infrastructure config:  ./infrastructure/scripts/configure-env.sh <ENV> <PROVIDER>
+    2. Deploy infrastructure:           make infra-apply ENVIRONMENT=<ENV> ENVIRONMENT_FILE=<FILE>
+    3. Generate application config:     make app-config ENVIRONMENT=<ENV> ENVIRONMENT_FILE=<FILE>
+    4. Deploy application:              make app-deploy ENVIRONMENT=<ENV> ENVIRONMENT_FILE=<FILE>
 EOF
 }