Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Commit 0a36bbc

Browse files
committed
fix: [#14] correct configure-env test logic to eliminate CI warning
The test was incorrectly expecting the configure-env.sh script to fail when called without parameters, but the script is designed to use sensible defaults ('local' environment). Changes: - Fixed test logic to expect success when script uses defaults - Replaced warning message with proper success validation - Added proper error handling when script actually fails This eliminates the CI warning: '[WARNING] Script should handle missing parameters gracefully' The script DOES handle missing parameters gracefully by using defaults, so the test should validate this behavior correctly.
1 parent efd79da commit 0a36bbc

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

infrastructure/tests/scripts/test-configure-env.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,12 @@ test_configure_env_error_handling() {
6363
# Test with invalid environment names
6464
log_info "Testing invalid environment handling..."
6565

66-
# Test with empty parameters
66+
# Test with empty parameters - script should succeed with defaults
6767
if "${SCRIPT_PATH}" >/dev/null 2>&1; then
68-
log_warning "Script should handle missing parameters gracefully"
68+
log_success "Script properly handles missing parameters by using defaults"
6969
else
70-
log_info "Script properly handles missing parameters"
70+
log_error "Script failed when it should use default parameters"
71+
failed=$((failed + 1))
7172
fi
7273

7374
log_success "Configuration script error handling tests completed"

0 commit comments

Comments
 (0)