Skip to content

Commit 0a009bb

Browse files
committed
trimming: don't abort where we used to resolve dynamic calls
This call resolution code was deleted in JuliaLang#56179 (rightfully so - this code really should never have been here in the first place) but it should be a no-op not an abort, until we implement this in inference.
1 parent 8bdacc3 commit 0a009bb

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/codegen.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5774,7 +5774,8 @@ static jl_cgval_t emit_call(jl_codectx_t &ctx, jl_expr_t *ex, jl_value_t *rt, bo
57745774
}
57755775
int failed_dispatch = !argv[0].constant;
57765776
if (ctx.params->trim != JL_TRIM_NO) {
5777-
abort(); // this code path is unsound, unsafe, and probably bad
5777+
// TODO: Implement the last-minute call resolution that used to be here
5778+
// in inference instead.
57785779
}
57795780

57805781
if (failed_dispatch && trim_may_error(ctx.params->trim)) {

0 commit comments

Comments
 (0)