Fix for Issue #560 Don't return members to user without enough permission #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T /projects/{id} endpoints if user has permission READ_PROJECT_MEMBER.
maxceem
suggested changes
May 8, 2020
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@gets0ul it works good, the only thing we have to keep the existent tests should not return "email" for project members when "fields" query param is not defined (to non-admin users) and should not return "email" for project members even if it\'s listed in "fields" query param (to non-admin users). I guess they fail now, because for testing we are using a user who is invited but not a member, thus members are not returned. In such case we can adjust these test cases and use a another regular user who is a member of the project.
…oint. - Revert test and use another regular user.
Contributor
Author
|
@maxceem PR is updated |
maxceem
approved these changes
May 11, 2020
maxceem
changed the base branch from
hotfix/post-release-2.4.1
to
feature/members-invites-permission-fixes
maxceem
merged commit 6103784
into
topcoder-platform:feature/members-invites-permission-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only return members with project object in these GET /projects and GET /projects/{id} endpoints if user has permission READ_PROJECT_MEMBER.