Skip to content

Conversation

@Jaouad-Jaghrir
Copy link
Contributor

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for final fixes @Schpotsky. Most them works well. There are only 2 tasks require some improvements:

  1. New command to make the column NOT NULL doesn't work:

    image

    Also, I've noticed that other SQL commands don't work also:

    image

    image

    image

  2. You've removed checking if delete has been called in DELETE endpoint when the link is removed. Instead of this, could you please keep this code in unit test, but check that delete is NOT called for link:

    image

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works good now, thanks @Schpotsky

@maxceem maxceem merged commit a26323d into topcoder-platform:feature/link-attachments Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants