Feature/project templates refactoring #283
Conversation
…efactoring (submission + final fixes) also includes small error message fixes and supporting 'null' for scope, phases, form, planConfig, priceConfig for create and update endpoints of projectTemplates
vikasrohit
left a comment
vikasrohit
left a comment
There was a problem hiding this comment.
I think we need to refactor the productTemplate as well. If not in this long PR, we can take it separately, but we have to do that as soon as we are done with this one.
Also, I have few comments, apart from that it looks good to me.
|
@maxceem merging the PR as we are going to take care of renaming of the |
|
@vikasrohit if you don't run migration scripts from this PR yet we can just rename these fields in migration scripts, rather than creating new migration scripts which would rename them to |
|
Yep, I haven't run the scripts yet. I was waiting for the PR to be deployed first. :) Yes, update the current migration script it self. |
The work initially has been done in the CODE challenge https://www.topcoder.com/challenges/30086308/?type=develop but has various issues and didn't get the passing score.
It was fixed via private task https://www.topcoder.com/challenges/30087019
All the issues were well elaborated. In general the quality of submission looks good.